[ROCm]: fix: reduce pipeline temp memory — replace ppermute collectives with lax.slice/pad (PR2) #4192
Open
cj401-amd wants to merge 3 commits into
Open
Conversation
…o yml can reference it
…ipeline_save_decoder_layer_input flag
face36a to
62907cf
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
shard_map+ppermutecollective operations in the pipeline with purelax.slice/jnp.pad/jnp.concatenateequivalents. This eliminates the shard_mapoverhead and removes stage-axis sharding constraints that caused temp memory bloat
and shape-divisibility errors.
Changes in
PipelineBase.get_new_loop_state:_rotate_right:shard_map+ppermute→lax.slice_in_dim+concatenate_shift_right:shard_map+ppermute+where→pad+lax.slice_update_state_io:shard_map+_rotate_left/_shift_left→pad+slice_in_dim+where(also removes extrastream_buf_idxarg)Changes in
PipelineBase.get_iteration_inputs:_maybe_shard_with_logicalcalls onshiftandfirst_stage_inout_shardingfrombroadcasted_iotaOther:
_maybe_shard_with_nameonmicrobatches_processedinget_microbatch_and_repeat_idsget_pipeline_remat_policyconditional onpipeline_save_decoder_layer_input:when
False, omitdecoder_layer_inputfrom saved names to reduce remat temp memoryTest plan
python3 -m pytest tests/unit/train_compile_test.py -v -k "pipeline"python3 -m pytest tests/integration/pipeline_parallelism_test.py -vpipeline_save_decoder_layer_input=false