[ROCm]: fix: reduce MoE temp memory — embedding cap, weight sum default, skip trivial specs (PR3)#4193
Open
cj401-amd wants to merge 4 commits into
Open
Conversation
…o yml can reference it
…ipeline_save_decoder_layer_input flag
… default, skip_trivial_specs
666bf09 to
0ed140e
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
use_iota_embedto ≤2 GiB one-hot size to prevent OOM on largevocabularies; add explicit
nn.with_logical_constraintafter embedding lookupfloat32_weight_sumdefault fromtruetofalse— the f32upcast adds ~2 GB temp per device with minimal numerical benefit for most configs
fsdp_transposeandcontextaxes; use
remove_size_one_mesh_axishelper; remove redundantjax.reshardcallsnn.with_logical_constraintwithmaybe_shard_with_logical(..., skip_trivial_specs=True)throughoutMixtralDecoderLayerto avoid no-op shardingconstraints that add XLA overhead
Test plan
python3 -m pytest tests/unit/train_compile_test.py -v -k "moe or deepseek or mixtral"