Skip to content

Rename Github workflows for consistency#4196

Merged
copybara-service[bot] merged 1 commit into
mainfrom
github_workflow_reorg
Jun 18, 2026
Merged

Rename Github workflows for consistency#4196
copybara-service[bot] merged 1 commit into
mainfrom
github_workflow_reorg

Conversation

@SurbhiJainUSC

@SurbhiJainUSC SurbhiJainUSC commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Description

This PR renames and reorganizes the GitHub workflows to establish a consistent naming convention across the repository. Previously, the .github/workflows directory contained a mix of PascalCase, kebab-case, and snake_case filenames, along with non-workflow scripts.

Key Changes:

  • Standardized naming to snake_case: All workflow files have been renamed to follow the snake_case convention to match the most prevalent style in the repository.
  • Improved workflow clarity:
    • build_and_test_maxtext.ymlci_pipeline.yml: Reflects its role as the top-level pipeline that orchestrates various test suites and sub-workflows.
    • UploadDockerImages.yml → nightly_images_pipeline.yml`: Reflects its role as the scheduled (nightly) Docker build process.

Why this change is being made:

Standardizing these names improves the maintainability of the CI/CD pipeline and makes it easier for contributors to navigate the repository.

Tests

N/A

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@SurbhiJainUSC SurbhiJainUSC force-pushed the github_workflow_reorg branch 3 times, most recently from a157dea to 6f4fe96 Compare June 18, 2026 01:02
@github-actions

Copy link
Copy Markdown

🤖 Hi @SurbhiJainUSC, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

@github-actions

Copy link
Copy Markdown

🤖 Hi @SurbhiJainUSC, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

@github-actions

Copy link
Copy Markdown

🤖 I'm sorry @SurbhiJainUSC, but I was unable to process your request. Please see the logs for more details.

@github-actions

Copy link
Copy Markdown

🤖 CI Failure Investigation Report

I have analyzed the recent test failures in the CI pipeline and identified the following:

🔍 What Failed

  • Job/Matrix: maxtext_jupyter_notebooks / run
  • Failing Test: Jupyter Notebook execution (completed 21/21 cells, but failed during self-hosted runner post-job cleanup)
  • Error: FetchError: request to https://34.118.224.1/api/v1/namespaces/.../secrets... failed, reason: connect ETIMEDOUT

🪵 Error Details & Stack Trace

maxtext_jupyter_notebooks / run	2026-06-18T00:55:07.2501859Z ##[error]FetchError: request to https://34.118.224.1/api/v1/namespaces/maxtext-linux-x86-ct6e-180-8tpu/secrets?labelSelector=runner-pod%3Dlinux-x86-ct6e-180-8tpu-mwpcs-runner-hsths failed, reason: connect ETIMEDOUT 34.118.224.1:443
maxtext_jupyter_notebooks / run	2026-06-18T00:55:07.2580117Z ##[error]Process completed with exit code 1.
maxtext_jupyter_notebooks / run	2026-06-18T00:55:07.2599705Z ##[error]Executing the custom container implementation failed. Please contact your self hosted runner administrator.

💡 Root Cause Analysis & Context

Confidence: high

The failure is an infrastructure/environment flake and is completely independent of the changes introduced in this PR.

Analysis:

  1. This PR (Rename Github workflows for consistency #4196) standardizes GitHub Action workflow naming conventions to snake_case and does not modify any model code or notebook configurations.
  2. The Jupyter Notebook executed successfully, passing 100% of its cells (Executing: 100%|██████████| 21/21 [12:04<00:00, 34.49s/cell]).
  3. After execution, during the self-hosted GKE runner's cleanup phase, the runner failed to connect to the Kubernetes API server control plane (34.118.224.1:443) with an ETIMEDOUT connection error. This triggered the job runner crash.

We recommend triggering a re-run of this job, as the failure is purely infrastructural.

@hengtaoguo hengtaoguo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean up!

@copybara-service copybara-service Bot merged commit d11b0d8 into main Jun 18, 2026
65 of 66 checks passed
@copybara-service copybara-service Bot deleted the github_workflow_reorg branch June 18, 2026 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants