add dummy argument to CreateLike for particlecontainers to match the …#4657
Open
srichers wants to merge 2 commits intoAMReX-Codes:developmentfrom
Open
add dummy argument to CreateLike for particlecontainers to match the …#4657srichers wants to merge 2 commits intoAMReX-Codes:developmentfrom
srichers wants to merge 2 commits intoAMReX-Codes:developmentfrom
Conversation
…signature for multifabs
atmyers
reviewed
Sep 16, 2025
Src/Base/AMReX_IntegratorBase.H
Outdated
| { | ||
|
|
||
| static void CreateLike (amrex::Vector<std::unique_ptr<T> >& V, const T& Other) | ||
| static void CreateLike (amrex::Vector<std::unique_ptr<T> >& V, const T& Other, bool dummy = false) |
Member
There was a problem hiding this comment.
I suggest:
Suggested change
| static void CreateLike (amrex::Vector<std::unique_ptr<T> >& V, const T& Other, bool dummy = false) | |
| static void CreateLike (amrex::Vector<std::unique_ptr<T> >& V, const T& Other, bool /*dummy*/ = false) |
to avoid unused parameter warnings.
atmyers
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…signature for multifabs
Summary
Modify the CreateLike function in IntegratorBase so all template specializations have the same function signature.
Additional background
Used in initialize_stages called in, for example RKIntegrator.
Addresses #4656 I think.
Checklist
The proposed changes: