Skip to content

Fix multiple calls of ReduceOps::eval_mf #5323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WeiqunZhang wants to merge 2 commits into
base: development
Choose a base branch
from
+4 −2
Open

Fix multiple calls of ReduceOps::eval_mf #5323

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b9c01c
Fix multiple calls of `ReduceOps::eval_mf`
WeiqunZhang Apr 14, 2026
2f9385b
Fix warning
WeiqunZhang Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Src/Base/AMReX_Reduce.H
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -631,7 +631,9 @@ public:
auto pdst = reduce_data.devicePtr(stream);
int nblocks_ec = std::min(nblocks, reduce_data.maxBlocks());
AMREX_ASSERT(Long(nblocks_ec)*2 <= Long(std::numeric_limits<int>::max()));
reduce_data.nBlocks(stream) = nblocks_ec;
int& nblocks_ref = reduce_data.nBlocks(stream);
auto old_nblocks = static_cast<unsigned int>(nblocks_ref);
nblocks_ref = amrex::max(nblocks_ref, nblocks_ec);
reduce_data.updateMaxStreamIndex(stream);

#ifdef AMREX_USE_SYCL
Expand All @@ -651,7 +653,7 @@ public:
ReduceTuple r;
Reduce::detail::for_each_init<0, ReduceTuple, Ps...>(r);
ReduceTuple& dst = pdst[blockIdx.x];
if (threadIdx.x == 0) {
if (threadIdx.x == 0 && blockIdx.x >= old_nblocks) {
dst = r;
}
for (int iblock = blockIdx.x; iblock < nblocks; iblock += nblocks_ec) {
Expand Down
Loading