Skip to content

Bug/fix test attitude setpoint test #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LorenzzoQM merged 2 commits into from
Mar 9, 2026
Merged

Bug/fix test attitude setpoint test #336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8e900e
[#335] Relax TestAttitudeSetpoint test tolerance
LorenzzoQM Mar 9, 2026
f42cbac
[#335] Update release notes
LorenzzoQM Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/source/release_notes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ Development - |version|
Custom code should update ``min_shadow_factor`` to ``min_illumination_factor`` and
``shadowFactor`` to ``illuminationFactor`` where these names are referenced.
* Fix target angle rate observation. ``r_BN_P`` is now correctly used instead of ``v_BN_P``.
* Relax ``TestAttitudeSetpoint`` test tolerance to account for different initial conditions and avoid eventual failures.

.. warning::

Expand Down
4 changes: 2 additions & 2 deletions tests/integration/act/test_int_actions_continuous.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ class AttitudeSat(sats.Satellite):
dyn_type = dyn.DynamicsModel
fsw_type = fsw.FSWModel
observation_spec = [obs.SatProperties(dict(prop="sigma_BN"))]
action_spec = [act.AttitudeSetpoint(control_period=360.0)]
action_spec = [act.AttitudeSetpoint(control_period=540.0)]

env = gym.make(
"SatelliteTasking-v1",
Expand All @@ -94,4 +94,4 @@ class AttitudeSat(sats.Satellite):

env.reset()
observation, _, _, _, _ = env.step([0.1, 0.2, 0.3])
assert np.allclose(observation, np.array([0.1, 0.2, 0.3]), atol=1e-4)
assert np.allclose(observation, np.array([0.1, 0.2, 0.3]), atol=2e-3)