Skip to content

Fix: OTelLinksResponse.count over-counts and writes a removed dropped field #4346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
justin212407 wants to merge 2 commits into
base: main
Choose a base branch
from
+1 −2
Open

Fix: OTelLinksResponse.count over-counts and writes a removed dropped field #4346

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cae034b
fix: OTelLinksResponse.count over-counts and writes a removed dropped…
justin212407 May 16, 2026
b4bad56
Merge branch 'main' into tracing-ingest-issue
justin212407 May 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions api/oss/src/apis/fastapi/tracing/router.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,9 +301,8 @@ async def ingest_spans( # MUTATION
)

link_response = OTelLinksResponse(
count=len(links) + len(dropped),
count=len(links),
links=links,
dropped=dropped or None,
)

return link_response
Expand Down
Loading