-
Notifications
You must be signed in to change notification settings - Fork 13
Bref serverless support #414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ioaniftimesei
wants to merge
16
commits into
main
Choose a base branch
from
bref_serverless_support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 9 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
f3dc999
Added support for additional PHP installation paths and improved hand…
ioaniftimesei b8dfdc6
Add workflow to build Lambda layers for multiple PHP versions and upd…
ioaniftimesei 396bd46
Refactor Lambda layer build process to utilize artifact paths for ext…
ioaniftimesei b7bd588
Refactor socket and PID path initialization to use dynamic runtime di…
ioaniftimesei 01ef84c
Update Lambda layer build process to correct directory structure and …
ioaniftimesei af20dda
debug
ioaniftimesei c520bd4
Refactor runtime directory initialization to check for writable run d…
ioaniftimesei 4cf396a
Update isRunDirWritable function to use os.WriteFile for checking wri…
ioaniftimesei d5c523c
test
ioaniftimesei 7399dc8
Pass IsLambda to go modules
ioaniftimesei 2fc8720
5s max loop for socket check
ioaniftimesei 4b2df34
+
ioaniftimesei d87d11f
Merge branch 'main' into bref_serverless_support
ioaniftimesei 0c3250e
+
ioaniftimesei 35a1bf2
+
ioaniftimesei 48726f1
Apply suggestions from code review
ioaniftimesei File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agent::Init adds an inlined polling loop that returns from inside the loop; extract or convert this wait into a guard/helper (early-return) to flatten Init's control flow and improve readability.
Details
✨ AI Reasoning
Agent::Init was modified to add a polling loop that waits for the agent socket to appear, returning from inside the loop when ready or logging a warning after the loop. This increases nesting and mixes startup orchestration with waiting logic, which could be clearer if the wait were a separate guard/helper or inverted into an early-return check. The change makes the control flow less linear and slightly harder to follow, so a guard/early-return or small helper function would improve maintainability.
🔧 How do I fix it?
Place parameter validation and guard clauses at the function start. Use early returns to reduce nesting levels and improve readability.
Reply
@AikidoSec feedback: [FEEDBACK]to get better review comments in the future.Reply
@AikidoSec ignore: [REASON]to ignore this issue.More info