Skip to content

feat(LocaleSelect): Make auto_submit toggable#3835

Merged
tvdeyen merged 1 commit intomainfrom
locale-select-auto-submit-option
Apr 15, 2026
Merged

feat(LocaleSelect): Make auto_submit toggable#3835
tvdeyen merged 1 commit intomainfrom
locale-select-auto-submit-option

Conversation

@tvdeyen
Copy link
Copy Markdown
Member

@tvdeyen tvdeyen commented Apr 14, 2026

What is this pull request for?

We need to be able to disable the auto-submit feature if we use the LocaleSelect in a form that submits via a button (ie. the users form of alchemy-devise).

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

We need to be able to disable the auto-submit feature
if we use the LocaleSelect in a form that submits via
a button (ie. the users form of alchemy-devise).
@tvdeyen tvdeyen requested a review from a team as a code owner April 14, 2026 08:54
@tvdeyen tvdeyen added the backport-to-8.2-stable Needs to be backported to 8.2-stable label Apr 14, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.06%. Comparing base (4849dff) to head (5f3c4e4).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3835   +/-   ##
=======================================
  Coverage   98.06%   98.06%           
=======================================
  Files         322      322           
  Lines        8526     8530    +4     
=======================================
+ Hits         8361     8365    +4     
  Misses        165      165           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tvdeyen tvdeyen added backport-to-8.0-stable Needs to be backported to 8.0-stable backport-to-8.1-stable Needs to be backported to 8.1-stable labels Apr 14, 2026
@tvdeyen tvdeyen merged commit 39ac6ea into main Apr 15, 2026
31 checks passed
@tvdeyen tvdeyen deleted the locale-select-auto-submit-option branch April 15, 2026 07:03
@alchemycms-bot
Copy link
Copy Markdown

💔 Some backports could not be created

Status Branch Result
8.0-stable Backport failed because of merge conflicts
8.1-stable Backport failed because of merge conflicts
8.2-stable

Manual backport

To create the backport manually run:

backport --pr 3835

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@tvdeyen tvdeyen removed backport-to-8.0-stable Needs to be backported to 8.0-stable backport-to-8.1-stable Needs to be backported to 8.1-stable labels Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-to-8.2-stable Needs to be backported to 8.2-stable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants