Develop - #19
Open
Ayusch wants to merge 3 commits into
Open
Conversation
AleSpero
requested changes
Aug 27, 2018
AleSpero
left a comment
AleSpero
left a comment
Owner
There was a problem hiding this comment.
Hello Ayusch,
Everything seems fine, but please don't commit any file under the .idea directory because they are mostly configuration files created by Android Studio and useless for the library. I will update the .gitignore file so they won't be tracked anymore.
If you also could update all the library versions (as done in the other pull request) i will merge this one so we will not have any kind of conflicts.
Thanks
Author
|
Hey, Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Added functionality to change title color and header background color. Also updated build.gradle minSdkVersion to 18.
Tested for functionality as well.
Please review and merge the features into master.
Regards