Open
Conversation
Contributor
|
@LuizFNJ this is still missing the token creation step. |
e140e7d to
a56e559
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
During this process, I had some doubts, especially about whether this was exactly what was expected, but I believe this serves as a base and we can improve on it if needed.
In this PR, I basically created an external API inside this repository that makes requests to the Aletheia claim creation API.
Local Testing Setup
I tested this locally by running the Aletheia platform on port
4000and this repository (the external API) on port3000. This setup allowed me to successfully send requests between the two systems:Example Requests
Directly to Aletheia API:
Through the External API:
Next Steps
Given that, could I reuse the same controller and simply adjust the logic based on the content of the body, or would I actually need to create a separate controller, service, and everything else?