Antalya 26.3: apassos-1405: combined port of 5 PRs#1672
Open
zvonand wants to merge 5 commits intoantalya-26.3from
Open
Antalya 26.3: apassos-1405: combined port of 5 PRs#1672zvonand wants to merge 5 commits intoantalya-26.3from
zvonand wants to merge 5 commits intoantalya-26.3from
Conversation
fc20cb6 to
7c8db01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Forward port of list objects cache #1040 (#1405 by @arthurpassos, #1388 by @arthurpassos, #1593 by @arthurpassos, #1517 by @arthurpassos, #1631 by @arthurpassos).
CI/CD Options
Exclude tests:
Regression jobs to run:
Combined port of 5 PR(s) (group
apassos-1405). Cherry-picked from #1405, #1388, #1593, #1517, #1631.#1405: Antalya 26.1 - Forward port of list objects cache #1040
Documentation entry for user-facing changes
Cache for listobjects calls
#1388: Antalya 26.1 - Forward port of export part and partition
Documentation entry for user-facing changes
Export merge tree part and partition (we still need to rebase #1177 afterwards)
#1593: Export Partition - release the part lock when the query is cancelled
During export partition, parts are locked by replicas for exports. This PR introduces a change that releases these locks when an export task is cancelled. Previously, it would not release the lock. We did not catch this error before because the only cases an export task was cancelled we tested were
KILL EXPORT PARTITIONandDROP TABLE. In those cases, the entire task is cancelled, so it does not matter if a replica does not release its lock.But a query can also be cancelled with 'SYSTEM STOP MOVES', and in that case, it is a local operation. The lock must be released so other replicas can continue.
Documentation entry for user-facing changes
...
#1517: Fix IPartitionStrategy race condition
IPartitionStrategy::computePartitionKey might be called from different threads, and it writes to cached_result concurrently without any sort of protection. It would be easier to add a mutex around it, but we can actually make it lock-free by moving the cache write to the constructor.
Documentation entry for user-facing changes
...
#1631: Fix condition for using parquet metadata cache
Apache Iceberg queries were not htiting the parquet metadata cache because
object_info->getFileFormat()resolves toIcebergDataObjectInfo::getFileFormat, which gets its return value fromIcebergObjectSerializableInfo. This field is filled with the value from Apache Iceberg manifest file, and it is upper case by default, which then fails clickhouse check for parquet metadata cache usage.Documentation entry for user-facing changes
...