-
Notifications
You must be signed in to change notification settings - Fork 152
feat: publish frontend Docker image to GHCR (issue #239) #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| .git | ||
| .github | ||
| .claude | ||
| .vscode | ||
| .sisyphus | ||
| .omo | ||
| .writing | ||
| server | ||
| node_modules | ||
| dist | ||
| build | ||
| electron | ||
| upload | ||
| versions | ||
| LandingPage | ||
| cloudflare-worker | ||
| assets | ||
| templates | ||
| *.md | ||
| .DS_Store |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| name: Publish Frontend Docker Image to GHCR | ||
|
|
||
| on: | ||
| push: | ||
| branches: [main] | ||
| tags: ['v*'] | ||
| workflow_dispatch: | ||
|
|
||
| env: | ||
| REGISTRY: ghcr.io | ||
| IMAGE_NAME: ${{ github.repository_owner }}/github-stars-manager-frontend | ||
|
|
||
| jobs: | ||
| build-and-push: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| packages: write | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
| with: | ||
| persist-credentials: false | ||
|
|
||
| - name: Set up QEMU | ||
| uses: docker/setup-qemu-action@c7c53464625b32c7a7e944ae62b3e17d2b600130 # v3 | ||
|
|
||
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@8d2750c68a42422c14e847fe6c8ac0403b4cbd6f # v3 | ||
|
|
||
| - name: Login to GitHub Container Registry | ||
| uses: docker/login-action@c94ce9fb468520275223c153574b00df6fe4bcc9 # v3 | ||
| with: | ||
| registry: ${{ env.REGISTRY }} | ||
| username: ${{ github.actor }} | ||
| password: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: Extract metadata (tags, labels) | ||
| id: meta | ||
| uses: docker/metadata-action@c299e40c65443455700f0fdfc63efafe5b349051 # v5 | ||
| with: | ||
| images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }} | ||
| tags: | | ||
| # branch push → "latest" | ||
| type=raw,value=latest,enable={{is_default_branch}} | ||
| # tag push → "v1.2.3", "1.2.3", "1.2", "1" | ||
| type=semver,pattern={{version}} | ||
| type=semver,pattern={{major}}.{{minor}} | ||
| type=semver,pattern={{major}} | ||
| # every build → sha-abc1234 | ||
| type=sha,prefix=sha- | ||
|
|
||
| - name: Build and push Docker image | ||
| uses: docker/build-push-action@10e90e3645eae34f1e60eeb005ba3a3d33f178e8 # v6 | ||
| with: | ||
| context: . | ||
| platforms: linux/amd64,linux/arm64 | ||
| push: true | ||
| tags: ${{ steps.meta.outputs.tags }} | ||
| labels: ${{ steps.meta.outputs.labels }} | ||
| cache-from: type=gha | ||
| cache-to: type=gha,mode=max | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,9 +31,9 @@ http { | |
| server { | ||
| listen 80; | ||
| server_name localhost; | ||
| # Backend API proxy | ||
| # Backend API proxy (configurable via BACKEND_HOST, default: backend:3000) | ||
| location /api/ { | ||
| set $backend_upstream backend:3000; | ||
| set $backend_upstream ${BACKEND_HOST}; | ||
| proxy_pass http://$backend_upstream; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Using a variable in By directly substituting the Note: Once this is applied, you can also safely remove or comment out the |
||
| proxy_http_version 1.1; | ||
| proxy_set_header Host $host; | ||
|
|
@@ -60,19 +60,19 @@ http { | |
| add_header 'Content-Length' 0 always; | ||
| return 204; | ||
| } | ||
|
|
||
| root /usr/share/nginx/html; | ||
| index index.html index.htm; | ||
|
|
||
| # Try to serve file, if not found, serve index.html (for SPA routing) | ||
| try_files $uri $uri/ /index.html; | ||
|
|
||
| # Add CORS headers for all responses | ||
| add_header 'Access-Control-Allow-Origin' '*' always; | ||
| add_header 'Access-Control-Allow-Credentials' 'true' always; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. According to the CORS specification, the Since these are static assets served by Nginx, credentials are not required for CORS. Removing the |
||
| add_header 'Access-Control-Allow-Methods' 'GET, POST, PUT, DELETE, OPTIONS' always; | ||
| add_header 'Access-Control-Allow-Headers' 'DNT,User-Agent,X-Requested-With,If-Modified-Since,Cache-Control,Content-Type,Range,Authorization' always; | ||
|
|
||
| # Add security headers | ||
| add_header X-Frame-Options "SAMEORIGIN" always; | ||
| add_header X-XSS-Protection "1; mode=block" always; | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.