tidy: msgq Windows support (review copy) - #3
Closed
AmyJeanes wants to merge 3 commits into
Closed
Conversation
AmyJeanes
force-pushed
the
windows-tidy
branch
4 times, most recently
from
September 9, 2026 04:42
fbd1656 to
381b5b3
Compare
Queues and fake-event state are named sections (no /dev/shm; a queue file that is only mapped cannot be swept). Readers wait on a per-thread event that publishers signal by thread id, in place of SIGUSR2, through the one deadline loop msgq_poll now uses everywhere; fake events are named events instead of FIFOs. visionipc duplicates section handles into the peer over AF_UNIX stream sockets, the Windows form of SCM_RIGHTS; sockets close via ipc_close(), and setenv/unsetenv are shimmed. Tests close their queues and time with perf_counter; msgq_shm_dir() replaces the /dev/shm vs /tmp ladders. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016AgqYZYWLpwE2T5vS3nVEt
Python imports extension modules as .pyd on Windows. The cython tool renames the .so targets the SConscripts declare, so neither they nor a SConstruct that loads the tool has to know. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016AgqYZYWLpwE2T5vS3nVEt
SCons takes the mingw tool with clang (the default picks MSVC), links libc++ statically so the binaries run outside the shell, and winsock for visionipc's sockets; setup.py copies the .pyd. setup.sh pins uv to a native CPython, MSYS2's own python being first on PATH; test.sh addresses the venv directory, not bin/python, so Scripts/ works too. CI gains a windows-latest entry in the CLANG64 shell, with five minutes for ./test.sh on the 4-core runner. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016AgqYZYWLpwE2T5vS3nVEt
AmyJeanes
force-pushed
the
windows-tidy
branch
from
September 9, 2026 17:14
381b5b3 to
eeb7743
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review copy of the Windows series rebased onto the line-ending branch and neatened: shared ipc_connect/ipc_bind and poll on every platform, one msgq_poll deadline loop with only the wait primitive per platform, MSG_WAITALL framing, setenv shims, shorter setup/test scripts and CI matrix. The os.environ mirroring commit moved to windows-followups (only openpilot's process replay needs it). Fork-internal, runs CI only.