V0.6.2 by SC426 · Pull Request #4 · AnacondaRecipes/y-py-feedstock

SC426 · 2024-03-08T02:52:45Z

y-py 0.6.2

Destination channel: defaults

Links

PKG-3801
Upstream repository
Upstream changelog/diff
Relevant dependency PRs:
- Version 1.76.0 rust-activation-feedstock#6
- V1.76 rust-feedstock#7

Explanation of changes:

Update version
Dependency updates
Add osx x86_64 compiler restraints Raise minimum supported Apple OS versions rust-lang/rust#104385

JeanChristopheMorinPerso · 2024-03-18T18:36:15Z

+rust_compiler_version:
+  - 1.76.0


Suggested change

rust_compiler_version:

- 1.76.0

This is already defined at line 3 and 4.

JeanChristopheMorinPerso · 2024-03-18T18:42:57Z

 build:
+  run_exports: # [osx and x86_64]
+    strong_constrains: # [osx and x86_64]
+      - __osx >={{ MACOSX_DEPLOYMENT_TARGET|default("10.12") }}  # [osx and x86_64]


Do we really need this? You'll get these for free if you use your latest builds for rust and rust-activation if I'm not mistaken.

I was just about to ask if this was required as well

JeanChristopheMorinPerso · 2024-03-18T18:44:33Z

    - wheel
+    - setuptools


Suggested change

- wheel

- setuptools

setuptools and wheel are not needed when using maturin.

Jrice1317 · 2024-03-18T18:58:09Z

  run:
    # this is needed otherwise import y_py in tests fails with ModuleNotFoundError
    - python
+    - __osx >=10.12     # [osx and x86_64]


Is this needed if the cbc.yaml has 10.12 listed for osx?

Jrice1317 · 2024-03-18T19:02:32Z

I noticed rust and rust-activation are both listed in the PR's description, but it seems a lot of what is done in this PR would be solved when rust is uploaded. Is that correct or am I missing something regarding the order of these PRs?

SC426 · 2024-03-18T19:03:33Z

I noticed rust and rust-activation are both listed in the PR's description, but it seems a lot of what is done in this PR would be solved when rust is uploaded. Is that correct or am I missing something regarding the order of these PRs?

They're linked here: https://github.com/AnacondaRecipes/y-py-feedstock/pull/4/files#diff-ff61408cdc05bc9667deeadb55e4aaceb1371972076b6bf6934f9008920f2bd2

JeanChristopheMorinPerso · 2024-03-18T20:09:08Z

https://staging.continuum.io/package/prefect/fs/y-py-feedstock/pr4/7c3f648/osx-64/y-py-0.6.2-py310h7854f77_0.conda shows that the osx-64 packages pins __osx >=10.9. This seems wrong to me... Shouldn't it be 10.12?

SC426 · 2024-03-18T20:14:00Z

https://staging.continuum.io/package/prefect/fs/y-py-feedstock/pr4/7c3f648/osx-64/y-py-0.6.2-py310h7854f77_0.conda shows that the osx-64 packages pins __osx >=10.9. This seems wrong to me... Shouldn't it be 10.12?

What was it before I removed the constraints? Tried to check myself but couldn't see.

anaconda-pkg-build · 2024-03-18T20:14:18Z

Linter check found the following problems:

ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_8as8sohmzd/clone` failed. (See above for error) The following problems have been found:

===== ERRORS =====

clone/recipe/meta.yaml:31: missing_wheel: For pypi packages, wheel should be present in the host section
===== Final Report: =====
1 Error and 0 Warnings were found

JeanChristopheMorinPerso · 2024-03-18T20:16:34Z

Actually, that's the constraint, not dep. Though, I would have expected __osx to be in the dependencies (in https://staging.continuum.io/package/prefect/fs/y-py-feedstock/pr4/7c3f648/osx-64/y-py-0.6.2-py310h7854f77_0.conda).

Jrice1317

Given everything builds successfully, LGTM!

JeanChristopheMorinPerso · 2024-03-18T20:23:43Z

Ah, I know what that constraints thing is. It's basically the run_constrained. Anyway, the version of __osx injected is wrong.

cbouss · 2024-03-18T20:35:46Z

Ah, I know what that constraints thing is. It's basically the run_constrained. Anyway, the version of __osx injected is wrong.

It might by the contrains export from the rust activation feedstock not being set because of two build sections.
We should rebuild from the latest commit of rust-activation and check the end result. But for now the osx-64 workers are busy..

anaconda-pkg-build · 2024-03-18T20:37:30Z

Linter check found the following problems:

ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_cd6x37k6gn/clone` failed. (See above for error) The following problems have been found:

===== ERRORS =====

clone/recipe/meta.yaml:31: missing_wheel: For pypi packages, wheel should be present in the host section
===== Final Report: =====
1 Error and 0 Warnings were found

SC426 · 2024-03-18T21:45:36Z

@JeanChristopheMorinPerso abd @cbouss the latest builds just finished.

JeanChristopheMorinPerso · 2024-03-18T21:47:51Z

Still looks wrong to me: https://staging.continuum.io/package/prefect/fs/y-py-feedstock/pr4/814e88b/osx-64/y-py-0.6.2-py310h7854f77_0.conda.

anaconda-pkg-build · 2024-03-19T19:51:41Z

Linter check found the following problems:

ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_72oa97vohw/clone` failed. (See above for error) The following problems have been found:

===== ERRORS =====

clone/recipe/meta.yaml:31: missing_wheel: For pypi packages, wheel should be present in the host section
===== Final Report: =====
1 Error and 0 Warnings were found

cbouss · 2024-03-19T20:05:34Z

4c5c04d

Now it's fine, we had conda_build_config.yaml misplaced in rust-activation.

anaconda-pkg-build · 2024-03-20T15:06:12Z

Linter check found the following problems:

ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_57q5jp7d84/clone` failed. (See above for error) The following problems have been found:

===== ERRORS =====

clone/recipe/meta.yaml:31: missing_wheel: For pypi packages, wheel should be present in the host section
===== Final Report: =====
1 Error and 0 Warnings were found

anaconda-pkg-build · 2024-03-20T15:15:22Z

Linter check found the following problems:

ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_508l_838n7/clone` failed. (See above for error) The following problems have been found:

===== ERRORS =====

clone/recipe/meta.yaml:31: missing_wheel: For pypi packages, wheel should be present in the host section
===== Final Report: =====
1 Error and 0 Warnings were found

SC426 added 16 commits March 7, 2024 18:05

update version and sha256

c8edd94

update dependencies

3a89760

add staging channel

6508dfa

try pinning maturin

e1236f2

add setuptools

df4174a

add staging channel;

24ed520

add build_config

bbe77c2

remove build_config

2f20fa2

fix typo

bc6ad78

add osx constrains

2a0fdc7

update compiler version for osx

dbf109d

test

05a9716

add cpython.yaml for 3.12

c0bbc80

revert conda-forge config files

e191347

pin osx to 10.12

84560bf

add conda_build_config

a3e7216

cbouss reviewed Mar 15, 2024

View reviewed changes

Comment thread recipe/meta.yaml Outdated

move osx contraints to main build section

e3b087c

AnacondaRecipes deleted a comment from anaconda-pkg-build Mar 18, 2024

add CONDA_BUILD_SYSROOT

f13a4ca

JeanChristopheMorinPerso reviewed Mar 18, 2024

View reviewed changes

Jrice1317 reviewed Mar 18, 2024

View reviewed changes

SC426 added 3 commits March 18, 2024 12:59

clean cbc

45843aa

remove setuptools and wheel

34a8a86

remove osx restraints from recipe

d581669

fix typo

7c3f648

AnacondaRecipes deleted a comment from anaconda-pkg-build Mar 18, 2024

SC426 requested a review from cbouss March 18, 2024 19:50

SC426 requested review from JeanChristopheMorinPerso and Jrice1317 March 18, 2024 19:50

SC426 closed this Mar 18, 2024

SC426 reopened this Mar 18, 2024

AnacondaRecipes deleted a comment from anaconda-pkg-build Mar 18, 2024

Jrice1317 approved these changes Mar 18, 2024

View reviewed changes

cbouss reviewed Mar 18, 2024

View reviewed changes

Comment thread abs.yaml Outdated

update abs.yaml

814e88b

update temp channel

4c5c04d

JeanChristopheMorinPerso approved these changes Mar 19, 2024

View reviewed changes

cbouss approved these changes Mar 19, 2024

View reviewed changes

SC426 added 2 commits March 20, 2024 09:03

remove staging channels

fad6416

remove abs.yaml

7d5dbf6

SC426 merged commit c60b7ad into main Mar 20, 2024

SC426 deleted the v0.6.2 branch March 20, 2024 15:14

Conversation

SC426 commented Mar 8, 2024 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Links

Explanation of changes:

Uh oh!

Uh oh!

JeanChristopheMorinPerso Mar 18, 2024

Choose a reason for hiding this comment

Uh oh!

JeanChristopheMorinPerso Mar 18, 2024

Choose a reason for hiding this comment

Uh oh!

Jrice1317 Mar 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JeanChristopheMorinPerso Mar 18, 2024

Choose a reason for hiding this comment

Uh oh!

Jrice1317 Mar 18, 2024

Choose a reason for hiding this comment

Uh oh!

Jrice1317 commented Mar 18, 2024

Uh oh!

SC426 commented Mar 18, 2024

Uh oh!

JeanChristopheMorinPerso commented Mar 18, 2024

Uh oh!

SC426 commented Mar 18, 2024

Uh oh!

anaconda-pkg-build commented Mar 18, 2024

Uh oh!

JeanChristopheMorinPerso commented Mar 18, 2024

Uh oh!

Jrice1317 left a comment

Choose a reason for hiding this comment

Uh oh!

JeanChristopheMorinPerso commented Mar 18, 2024

Uh oh!

Uh oh!

cbouss commented Mar 18, 2024

Uh oh!

anaconda-pkg-build commented Mar 18, 2024

Uh oh!

SC426 commented Mar 18, 2024

Uh oh!

JeanChristopheMorinPerso commented Mar 18, 2024

Uh oh!

anaconda-pkg-build commented Mar 19, 2024

Uh oh!

cbouss commented Mar 19, 2024

Uh oh!

anaconda-pkg-build commented Mar 20, 2024

Uh oh!

anaconda-pkg-build commented Mar 20, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

SC426 commented Mar 8, 2024 •

edited by atlassian Bot

Loading

Jrice1317 Mar 18, 2024 •

edited

Loading