Skip to content

refactor(whatsrust): extract event conversion - #301

Merged
Andiveli merged 4 commits into
betafrom
refactor/whatsrust-event-conversion
Aug 26, 2026
Merged

refactor(whatsrust): extract event conversion#301
Andiveli merged 4 commits into
betafrom
refactor/whatsrust-event-conversion

Conversation

@Andiveli

Copy link
Copy Markdown
Owner

Summary

  • Extract CEvent to Event conversion into events.rs.
  • Preserve specialized event mappings, discriminants, field conversion, and callback registration behavior.

Changes

  • Moved the event callback translator and chat, reaction, and message-action conversion helpers out of lib.rs.
  • Kept the root facade API and ABI unchanged.

Chain Context

Review Budget

  • Authored diff: 248 lines (128 additions, 120 deletions).
  • Budget: <=400 touched lines.

Testing

  • cargo fmt --all -- --check
  • git diff --check
  • Source checks confirm the event handler registration remains present.
  • Cargo compilation/tests: deferred explicitly to CI; not run locally.
  • Manual runtime testing: N/A for this mechanical extraction.

Rollback and Out of Scope

  • Rollback: revert commit 6a22a9a; only event conversion extraction is removed.
  • Out of scope: behavior fixes, API redesign, ABI changes, Cargo builds/tests, and unrelated cleanup.

Contributor Checklist

Closes #297

@Andiveli Andiveli added the type:refactor Code refactoring label Aug 26, 2026
@Andiveli
Andiveli changed the base branch from refactor/whatsrust-incoming-messages to beta August 26, 2026 23:40
@Andiveli
Andiveli merged commit ee112df into beta Aug 26, 2026
1 check passed
@Andiveli
Andiveli deleted the refactor/whatsrust-event-conversion branch August 31, 2026 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:refactor Code refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant