Skip to content

refactor(whatsrust): extract media wrappers - #314

Merged
Andiveli merged 2 commits into
betafrom
refactor/whatsrust-media-wrappers
Aug 27, 2026
Merged

refactor(whatsrust): extract media wrappers#314
Andiveli merged 2 commits into
betafrom
refactor/whatsrust-media-wrappers

Conversation

@Andiveli

Copy link
Copy Markdown
Owner

Summary

  • Extract profile-picture accessors/copying and file-download wrappers from the whatsrust facade.
  • Preserve C result ownership, byte copying, status mapping, public signatures, and ABI behavior.

Changes

  • Added whatsrust/src/media.rs.
  • Re-exported profile-picture accessors and download_file from lib.rs.
  • Moved the focused profile-picture mapping tests with their implementation.

Chain Context

  • Start: PR refactor(whatsrust): extract presence wrappers #313 (refactor/whatsrust-presence-wrappers).
  • End: media wrappers isolated; action wrappers remain.
  • Dependency: this PR is the immediate parent for the action slice.
  • Diagram: #301 -> #311 -> #312 -> #313 -> 📍 #314 -> #315.
  • Deferred: Cargo compilation/tests are intentionally deferred per task instructions; only formatting/source/diff checks were run.
  • Rollback: revert commit 14183b7 / remove media.rs and restore the media wrapper block in lib.rs; no unrelated behavior changes.

Testing

  • cargo fmt --check
  • git diff --check
  • Source and authored-line budget checks
  • Cargo tests/build (deferred; no Cargo build/test command run)
  • Manual runtime testing (not applicable to this mechanical extraction)

Closes #309

@Andiveli Andiveli added the type:refactor Code refactoring label Aug 26, 2026
@Andiveli
Andiveli changed the base branch from refactor/whatsrust-presence-wrappers to beta August 27, 2026 00:27
@Andiveli
Andiveli merged commit 88ce0fc into beta Aug 27, 2026
1 check passed
@Andiveli
Andiveli deleted the refactor/whatsrust-media-wrappers branch August 31, 2026 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:refactor Code refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant