Skip to content

refactor(whatsrust): make ABI dependencies explicit - #339

Merged
Andiveli merged 1 commit into
betafrom
refactor/whatsrust-explicit-abi-imports
Aug 27, 2026
Merged

refactor(whatsrust): make ABI dependencies explicit#339
Andiveli merged 1 commit into
betafrom
refactor/whatsrust-explicit-abi-imports

Conversation

@Andiveli

@Andiveli Andiveli commented Aug 26, 2026

Copy link
Copy Markdown
Owner

Summary

  • Remove the private use abi::*; facade import.
  • Make every affected Rust module and facade test import its ABI symbols from crate::abi explicitly.
  • Preserve behavior, public API, and ABI while making coupling auditable.

Changes

File Change
whatsrust/src/lib.rs Removed the wildcard ABI import; facade now contains module declarations and explicit reexports only.
whatsrust/src/{actions,facade_tests,lifecycle,media,presence,queries,read_sync,registrations}.rs Added or relocated explicit crate::abi::{...} imports for required bridge symbols.

Chain Context

Testing

  • cargo fmt --all -- --check
  • git diff --check
  • CARGO_TARGET_DIR=/home/samael/Escritorio/Programacion/public/wptui-public/target cargo check -p whatsrust --all-targets (passed, no warnings introduced)
  • CARGO_TARGET_DIR=/home/samael/Escritorio/Programacion/public/wptui-public/target cargo test -p whatsrust --lib -- --test-threads=1 (24 passed)
  • CARGO_TARGET_DIR=/home/samael/Escritorio/Programacion/public/wptui-public/target cargo test --test whatsrust_api_contract -- --test-threads=1 (1 passed)
  • Verified no use abi::* or abi::* remains in Rust sources.
  • Manual/runtime testing: N/A; source-ownership refactor with no behavior change.
  • Full workspace tests: not run; outside this focused child budget.

Review Budget and Rollback

Contributor Checklist

Closes #338

@Andiveli Andiveli added the type:refactor Code refactoring label Aug 26, 2026
@Andiveli
Andiveli changed the base branch from refactor/whatsrust-facade-final-cleanup to beta August 27, 2026 03:00
@Andiveli
Andiveli merged commit 5be229e into beta Aug 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:refactor Code refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant