P2P: Add gossip of BP peers

libraries/chain/controller.cpp

@@ -1322,9 +1322,6 @@ struct controller_impl {
          const auto& [ block, id] = t;
          wasmif.current_lib(block->block_num());
          vote_processor.notify_lib(block->block_num());
-
-         // update peer public keys from chainbase db 
-         peer_keys_db.update_peer_keys(self, block->block_num());
       });
 
 #define SET_APP_HANDLER( receiver, contract, action) \
@@ -5787,6 +5784,10 @@ void controller::set_peer_keys_retrieval_active(bool active) {
    my->peer_keys_db.set_active(active);
 }
 
+flat_set<name> controller::update_peer_keys(uint32_t lib_number) {
+   return my->peer_keys_db.update_peer_keys(*this, lib_number);
+}
+
 std::optional<public_key_type> controller::get_peer_key(name n) const {
    return my->peer_keys_db.get_peer_key(n);
 }

libraries/chain/include/eosio/chain/controller.hpp

@@ -428,6 +428,8 @@ namespace eosio::chain {
          chain_id_type get_chain_id()const;
 
          void set_peer_keys_retrieval_active(bool active);
+         // call on main thread with irreversible block
+         flat_set<name> update_peer_keys(uint32_t lib_number);
          std::optional<public_key_type> get_peer_key(name n) const; // thread safe
 
          // thread safe

libraries/chain/include/eosio/chain/peer_keys_db.hpp

@@ -23,8 +23,8 @@ class peer_keys_db_t {
 
    void set_active(bool b) { _active = b; }
 
-   // must be called from main thread
-   size_t update_peer_keys(const controller& chain, uint32_t lib_number);
+   // must be called from main thread, returns any new or updated producers
+   flat_set<name> update_peer_keys(const controller& chain, uint32_t lib_number);
 
    // safe to be called from any thread
    std::optional<public_key_type> get_peer_key(name n) const;

libraries/chain/peer_keys_db.cpp

@@ -19,10 +19,10 @@ size_t peer_keys_db_t::size() const {
 
 // we update the keys that were registered up to lib_number (inclusive)
 // --------------------------------------------------------------------
-size_t peer_keys_db_t::update_peer_keys(const controller& chain, uint32_t lib_number) {
-   size_t num_updated = 0;
+flat_set<name> peer_keys_db_t::update_peer_keys(const controller& chain, uint32_t lib_number) {
+   flat_set<name> result;
    if (!_active || lib_number <= _block_num)
-      return num_updated;                      // nothing to do
+      return result;                      // nothing to do
 
    try {
       const auto& db = chain.db();
@@ -38,7 +38,7 @@ size_t peer_keys_db_t::update_peer_keys(const controller& chain, uint32_t lib_nu
       if (upper == lower) {
          // no new keys registered
          _block_num = lib_number;
-         return num_updated;
+         return result;
       }
 
       fc::lock_guard g(_m); // we only need to protect access to _peer_key_map
@@ -75,15 +75,15 @@ size_t peer_keys_db_t::update_peer_keys(const controller& chain, uint32_t lib_nu
                EOS_ASSERT(data.pubkey->valid(), misc_exception, "deserialized invalid public key from `peerkeys`");
 
                _peer_key_map[row_name] = *data.pubkey;
-               ++num_updated;
+               result.insert(row_name);
             }
          }
          FC_LOG_AND_DROP(("skipping invalid record deserialized from `peerkeys`"));
       }
 
       _block_num = lib_number;                   // mark that we have updated up to lib_number
    } FC_LOG_AND_DROP(("Error when updating peer_keys_db"));
-   return num_updated;
+   return result;
 }
 
 } // namespace eosio::chain