Skip to content

fix: add outDir for tsconfig #7518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kyangconn wants to merge 2 commits into from
+18 −3
Closed

fix: add outDir for tsconfig #7518

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2147cdd
fix: add outDir for tsconfig
kyangconn Apr 13, 2026
958eee7
improve tsconfig options
kyangconn Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dashboard/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
"paths": {
"@/*": ["./src/*"]
},
"outDir": "dist",
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using dist as the outDir may conflict with Vite's default output directory. If tsc is ever run without the --noEmit flag (e.g., by an IDE or a static analysis tool), it will populate the dist folder with transpiled files, which could interfere with the production build or lead to the accidental deployment of unbundled code.

Regarding your concern about CI: since the build script in package.json uses vue-tsc --noEmit, this change will not affect the production build process as noEmit causes TypeScript to ignore the outDir setting. However, to avoid potential directory pollution, consider using a distinct directory like dist-tsc.

Suggested change
"outDir": "dist",
"outDir": "dist-tsc",

"allowJs": true
},

Expand Down
1 change: 1 addition & 0 deletions dashboard/tsconfig.vite-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"extends": "@vue/tsconfig/tsconfig.json",
"include": ["vite.config.*"],
"compilerOptions": {
"outDir": "dist",
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using dist here may cause collisions with the main project's output. Since this configuration is specifically for Vite configuration files and uses composite: true, it is recommended to use a separate output directory (e.g., dist-tsc-vite) to prevent build metadata (like .tsbuildinfo) from interfering with the main project's output if both are processed by a tool like tsc --build.

Suggested change
"outDir": "dist",
"outDir": "dist-tsc-vite",

"composite": true,
"allowJs": true,
"types": ["node"]
Expand Down
Loading