Skip to content

fix: prevent numeric input reset to 0 on text selection blur #7581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
uuutt2023 wants to merge 7 commits into from
+22 −3
Closed

fix: prevent numeric input reset to 0 on text selection blur #7581

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c50570f
fix: prevent numeric input reset to 0 on text selection blur
uuutt2023 Apr 15, 2026
f618409
fix(dashboard): optimize blur handler to avoid unnecessary emit
uuutt2023 Apr 15, 2026
0814db0
feat(dashboard): add form validation for numeric inputs
uuutt2023 Apr 15, 2026
8ed1aaa
refactor(dashboard): use Number.isFinite for consistent numeric valid…
uuutt2023 Apr 15, 2026
18adfac
refactor(dashboard): simplify handleNumericBlur by reducing nesting
uuutt2023 Apr 15, 2026
9085149
refactor(dashboard): replace comment with variable name hasValidInput
uuutt2023 Apr 15, 2026
a166bec
Merge branch 'master' into fix/issue-7423-numeric-input-reset
uuutt2023 Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dashboard/src/components/shared/ConfigItemRenderer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@
<v-text-field
:model-value="numericTemp ?? modelValue"
@update:model-value="val => (numericTemp = val)"
@blur="() => { emitUpdate(toNumber(numericTemp)); numericTemp = null }"
@blur="() => { emitUpdate(numericTemp != null ? toNumber(numericTemp) : modelValue); numericTemp = null }"
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this fix correctly prevents the value from being reset to 0 when numericTemp is null, emitting the modelValue back to the parent is redundant when no changes have been made (e.g., when the user just selects text and blurs). It's cleaner to only emit an update and reset the temporary state if the user has actually interacted with the input (i.e., numericTemp is not null). This avoids unnecessary event cycles and potential side-effects in the parent component.

        @blur="() => { if (numericTemp != null) { emitUpdate(toNumber(numericTemp)); numericTemp = null } }"

density="compact"
variant="outlined"
class="config-field"
Expand Down