Sbp 481 extension#108
Open
vtnphan wants to merge 3 commits into
Open
Conversation
vtnphan
marked this pull request as ready for review
July 22, 2026 04:46
marius-mather
requested changes
Jul 22, 2026
marius-mather
left a comment
marius-mather
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, let's just reduce the repetition and move the encoding logic in to a shared spot
| @@ -7,20 +7,25 @@ | |||
| import importlib | |||
|
|
|||
Collaborator
There was a problem hiding this comment.
Would be good to have some simple unit tests of encoding email addresses, to show the expected input and output
|
|
||
| account = ( | ||
| f"{user_details.user_email}:{encode_ip(user_details.ip_address)}" | ||
| f"{encode_value(user_details.user_email)}:{encode_value(user_details.ip_address)}" |
Collaborator
There was a problem hiding this comment.
This logic is being repeated multiple times, it should be moved into a shared function. You could create a get_encoded_account_details() method on UserDetails
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
SBP-481 Encode email in cluster options before sending to NCI GADI
Type of change
Checklist