-
Notifications
You must be signed in to change notification settings - Fork 60
chore(nix): various dev shell improvements #1306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
0xda157
wants to merge
9
commits into
Autodesk:dev
Choose a base branch
from
0xda157:nix-shell
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
ae6c714
flake.lock: update
0xda157 902f738
chore(nix): add node, bun, and git-lfs to dev shell
0xda157 9d776fb
chore(nix): move flake to top-level
0xda157 c175026
chore(nix): add dev shell for exporter
0xda157 c1a4df0
chore: use /usr/bin/env bash
0xda157 7acc86f
chore: add direnv for nix shells
0xda157 e7134fe
chore(ci): add checks for nix flake
0xda157 1305c8b
chore(nix): set default devShell to fission
0xda157 0211df1
chore(contributing.md): add development with nix section
0xda157 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| --- | ||
| name: Nix Flake - Check | ||
|
|
||
| on: | ||
| workflow_dispatch: {} | ||
| push: | ||
| branches: [ prod, dev ] | ||
| pull_request: | ||
| branches: [ prod, dev ] | ||
|
|
||
| jobs: | ||
| flake-check: | ||
| runs-on: ubuntu-24.04 | ||
| steps: | ||
| - uses: actions/checkout@v6 | ||
|
|
||
| - uses: cachix/install-nix-action@v31 | ||
|
|
||
| - run: nix flake check | ||
|
|
||
| formatting-check: | ||
| runs-on: ubuntu-24.04 | ||
| steps: | ||
| - uses: actions/checkout@v6 | ||
|
|
||
| - uses: cachix/install-nix-action@v31 | ||
|
|
||
| - run: nix fmt -- --ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,4 +8,5 @@ renderer/ | |
| .DS_Store | ||
| *.pkg | ||
| *.exe | ||
| .idea | ||
| .idea | ||
| **/.direnv | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| if command -v nix &>/dev/null; then | ||
| use flake .#exporter | ||
| fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| if command -v nix &>/dev/null; then | ||
| use flake .#fission | ||
| fi |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,8 +17,11 @@ | |
| in | ||
| { | ||
| devShells = forEachSupportedSystem (pkgs: { | ||
| default = pkgs.mkShell { | ||
| fission = pkgs.mkShell { | ||
| nativeBuildInputs = with pkgs; [ | ||
| nodejs | ||
| bun | ||
| git-lfs | ||
| playwright-driver.browsers | ||
| ]; | ||
|
|
||
|
|
@@ -27,8 +30,19 @@ | |
| PLAYWRIGHT_SKIP_VALIDATE_HOST_REQUIREMENTS = true; | ||
| }; | ||
| }; | ||
| exporter = pkgs.mkShell { | ||
| packages = with pkgs; [ | ||
| python3 | ||
| black | ||
| isort | ||
| bun | ||
| ]; | ||
| }; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @azaleacolburn Shell for using emscripten to compile Jolt? |
||
| }); | ||
|
|
||
| formatter = forEachSupportedSystem (pkgs: pkgs.nixfmt-tree); | ||
|
|
||
| # Build all devShells, instead of just verifying they are deviations | ||
| checks = forEachSupportedSystem (pkgs: inputs.self.devShells.${pkgs.stdenv.hostPlatform.system}); | ||
| }; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| if command -v nix &>/dev/null; then | ||
| use flake .#fission | ||
| fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| #!/bin/bash | ||
| #!/usr/bin/env bash | ||
| if ! [ -d ../api/Api/Gen/ ] | ||
| then | ||
| mkdir ../api/Api/Gen/ | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.