Skip to content

Subscriptions: register filesystem path for inline-style support #47988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dd32 wants to merge 1 commit into
base: trunk
Choose a base branch
from
+13 −1
Open

Subscriptions: register filesystem path for inline-style support #47988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/plugins/jetpack/changelog/fix-subscriptions-inline-styles-path
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: bugfix

Subscriptions: fix `wp_maybe_inline_styles` notice for the `jetpack-subscriptions` stylesheet by registering a filesystem path instead of a URL.
10 changes: 9 additions & 1 deletion projects/plugins/jetpack/modules/subscriptions/views.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,15 @@ public function enqueue_style() {
array(),
JETPACK__VERSION
);
wp_style_add_data( 'jetpack-subscriptions', 'path', $path );

// `wp_maybe_inline_styles()` requires a filesystem path, not a URL.
$style_path = JETPACK__PLUGIN_DIR . (
/** This filter is documented in projects/plugins/jetpack/load-jetpack.php */
apply_filters( 'jetpack_should_use_minified_assets', true )
? '_inc/build/subscriptions/subscriptions.min.css'
: 'modules/subscriptions/subscriptions.css'
);
wp_style_add_data( 'jetpack-subscriptions', 'path', $style_path );
}

/**
Expand Down
Loading