Fix for the case of giving erroneous value to {id} and function value…#1083
Open
ehsankhf wants to merge 1 commit intoAutomattic:masterfrom
Open
Fix for the case of giving erroneous value to {id} and function value…#1083ehsankhf wants to merge 1 commit intoAutomattic:masterfrom
ehsankhf wants to merge 1 commit intoAutomattic:masterfrom
Conversation
… to {jobType} arguments, in Job.get method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the case of calling the
It will raise an exception as the id's error is sent back by the non-determined third argument which is undefined.
The fix provides the correct order of argument validation inside the considered function.