perf(spark-runtime): opt-in NVTX kernel-attribution + phase-timing instrumentation#255
Open
Sujimoshi wants to merge 1 commit into
Open
Conversation
…strumentation Diagnostic-only (ATLAS_NVTX_DIAG=1), dlopen'd lazily so normal builds/runs carry no link-time or runtime dependency on libnvToolsExt. Split out of Avarok-Cybersecurity#218 (DFlash speculative decoding) — purely additive instrumentation, no behavior change to any existing code path. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Sujimoshi
requested review from
AzeezIsh,
SeedSource,
rsafier and
tbraun96
as code owners
This was referenced Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First of a planned split of #218 (DFlash speculative decoding) into smaller, independently reviewable PRs — see the split plan discussed on #218. This PR carries only the diagnostic instrumentation slice:
crates/spark-runtime/src/nvtx_diag.rs(new) — opt-in NVTX range instrumentation for kernel attribution, gated behindATLAS_NVTX_DIAG=1crates/spark-runtime/src/kernel_args.rs— per-op timing/profiling hookslibloadingdependency, dlopen'd lazily — normal builds/runs have no link-time or runtime dependency onlibnvToolsExtNo behavior change to any existing code path — purely additive, opt-in diagnostics.
Test plan
cargo check -p spark-runtime(ATLAS_SKIP_BUILD=1, CUDA stubbed) — cleancargo fmt --check -p spark-runtime— cleancargo clippy -p spark-runtime --tests(ATLAS_SKIP_BUILD=1) — no warningsATLAS_NVTX_DIAG=1on GB10 (requires live GPU, not exercised by this diff alone since it's dead code until wired up by later PRs in the split)🤖 Generated with Claude Code