feat(config): resolveConfig + typed layer ingest adapters#23391
Open
spypsy wants to merge 14 commits into
Open
feat(config): resolveConfig + typed layer ingest adapters#23391spypsy wants to merge 14 commits into
spypsy wants to merge 14 commits into
Conversation
f34df15 to
1a57134
Compare
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the unified resolution pipeline on top of
composeConfigMappings:resolveConfig(mappings, layers)— merges per-key layer values by priority (CLI → ENV → NETWORK → DEFAULT) and returns aResolvedConfig<T>carrying provenance for every key.envToTyped(mappings, env?)— reads env vars (includingfallbackanddeprecatedFallback) and returns only the keys actually set.getConfigFromMappingsnow delegates to it.cliToTyped(mappings, opts, namespace?)— extracts typed values from a Commander opts object. Namespace param disambiguates real per-component cases (bot/pxenodeUrl); composeConfigMappings handles in-component dedup.networkConfigToTyped(mappings, networkConfig)— peer adapter for the NETWORK layer. No env-string round-trip: passes native-typed fields through unchanged and dispatchesmapping.parseEnvfor string-typed fields that consumers expect structured (e.g.txPublicSetupAllowListExtend → AllowedElement[]viaparseAllowList, which lives in@aztec/p2p— foundation never imports it directly).findUniversalConfigKeys(...componentMappings)— detects which keys are auto-promotable to top-level CLI flags via mapping-object reference equality. Used by A-1067 to replace the manualuniversalOptionslist.Fixes A-989 and A-990.