fix: route @aztec/viem to npm in docs examples + verdaccio allow_offline#23397
Draft
AztecBot wants to merge 1 commit into
Draft
fix: route @aztec/viem to npm in docs examples + verdaccio allow_offline#23397AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small, related fixes for
@aztec/*resolution in docs example builds and the aztec-up packaging:docs/examples/ts/lib.sh— Add anAZTEC_NPM_EXCEPTIONSlist at the top, so bare@aztec/viemin aconfig.yamlis routed toNPM_DEPS(proxied from npm) instead of being auto-linked to a non-existentyarn-project/viem.aztec-up/bootstrap.sh— Bring inpublish: allow_offline: true(and its comment) fromcb/dd69e1f0bb2f(f66631b8c5). Prevents the local verdaccio from 503-ing fake-publishes when the npmjs uplink is briefly unreachable.Why @aztec/viem needs an exception
parse_dependencies()treats every bare@aztec/*entry as a local yarn-project package and resolves it tolink:.../yarn-project/<name>.@aztec/viemis a third-party fork on npm — there's noyarn-project/viem, so the auto-link blows up with "Link target does not exist". Existing configs work around this by spelling itnpm:@aztec/viem@2.38.2; the exception list makes the bare form safe too.Scan for other packages not published locally
Cross-checked everything used as
@aztec/*againstyarn-project/*and npm:@aztec/viem— the only one that needs the new exception (third-party, lives on npm, no local source)@aztec/bb.js,@aztec/noir-*— not inyarn-project/, but already handled via the explicitlink:pkg:pathform in configs (barretenberg/ts,noir/packages/*)yarn-project/So just
@aztec/viemfor now.Not changed (intentionally)
Existing
config.yamlfiles that saynpm:@aztec/viem@2.38.2are left alone — thenpm:form still works, and it keeps the explicit version pin (2.38.2). The new exception is a safety net for the bare form, not a migration target.Full analysis + verification: https://gist.github.com/AztecBot/fcbb5ff446d16891e758bcba38632ef3
ClaudeBox log: https://claudebox.work/s/b06b3be6cb06f86f?run=1