fix(ci): serialize noir-projects nargo dep download in Makefile#23403
Draft
AztecBot wants to merge 1 commit into
Draft
fix(ci): serialize noir-projects nargo dep download in Makefile#23403AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
aztec-nrstep failure onmerge-train/spartan(CI log http://ci.aztec-labs.com/1779205744876764):The Makefile builds
noir-protocol-circuits,mock-protocol-circuits,noir-contracts, andaztec-nrin parallel — each invokes its ownbootstrap.sh. Several share the samenoir-lang/poseidon@v0.3.0andnoir-lang/sha256@v0.3.0git deps, and four parallelnargoprocesses race on the shared~/nargo/...cache and outbound DNS. The loser surfaces the failure as a git clone error.noir-projects/bootstrap.shalready has a serialprepstep that documents and works around this race ("Use fmt as a trick to download dependencies. Otherwise parallel runs of nargo will trip over each other trying to download dependencies."), but it only runs whennoir-projects/bootstrap.shis invoked. The root Makefile bypasses it.Fix
prepto top-level innoir-projects/bootstrap.shso it can be invoked as./bootstrap.sh prep.buildstill calls it — no behavior change for the existing path.noir-projects-depsMakefile target that runsprepas a serial barrier, and make the four parallel noir-projects targets depend on it.Full analysis: https://gist.github.com/AztecBot/c5c82cfc1d739abebd228648bdfe34e4
Test plan
make -nd aztec-nrshowsnoir-projects-depsis scheduled once, before any of the four parallel sub-builds.bash -n noir-projects/bootstrap.shpasses../bootstrap.sh ciblocked by a container UID mismatch).ClaudeBox log: https://claudebox.work/s/5c5ca564e2a8aa3d?run=1