Skip to content

fix: reject block proposals in poisoned slots#23411

Merged
alexghr merged 1 commit into
merge-train/spartanfrom
ag/fix-reject-block-proposals-in-poisoned-slots
May 22, 2026
Merged

fix: reject block proposals in poisoned slots#23411
alexghr merged 1 commit into
merge-train/spartanfrom
ag/fix-reject-block-proposals-in-poisoned-slots

Conversation

@alexghr
Copy link
Copy Markdown
Contributor

@alexghr alexghr commented May 19, 2026

Reject syncing blocks with indexWithinCheckpoint > terminal block in checkpoint proposal

@alexghr alexghr force-pushed the ag/fix-reject-block-proposals-in-poisoned-slots branch from d76d756 to 55c43ea Compare May 20, 2026 10:16
@alexghr alexghr force-pushed the ag/fix-extend-slashing-of-bad-attestations branch from e935225 to 8d5dd3d Compare May 20, 2026 10:16
@alexghr alexghr force-pushed the ag/fix-reject-block-proposals-in-poisoned-slots branch from 55c43ea to 7a6b002 Compare May 20, 2026 13:30
@alexghr alexghr force-pushed the ag/fix-extend-slashing-of-bad-attestations branch from 8d5dd3d to 19f7e70 Compare May 20, 2026 13:30
@alexghr alexghr force-pushed the ag/fix-reject-block-proposals-in-poisoned-slots branch from 7a6b002 to 827ab34 Compare May 20, 2026 17:30
@alexghr alexghr force-pushed the ag/fix-extend-slashing-of-bad-attestations branch 2 times, most recently from c6288e1 to d6bbeea Compare May 21, 2026 09:35
@alexghr alexghr force-pushed the ag/fix-reject-block-proposals-in-poisoned-slots branch from 827ab34 to 18830ec Compare May 21, 2026 09:35
@alexghr alexghr force-pushed the ag/fix-extend-slashing-of-bad-attestations branch from d6bbeea to b7abf68 Compare May 21, 2026 09:38
@alexghr alexghr force-pushed the ag/fix-reject-block-proposals-in-poisoned-slots branch from 18830ec to 141121e Compare May 21, 2026 09:38
@alexghr alexghr force-pushed the ag/fix-extend-slashing-of-bad-attestations branch from b7abf68 to eba4c1e Compare May 21, 2026 11:38
@alexghr alexghr force-pushed the ag/fix-reject-block-proposals-in-poisoned-slots branch from 141121e to d26356e Compare May 21, 2026 11:38
@alexghr alexghr force-pushed the ag/fix-extend-slashing-of-bad-attestations branch from eba4c1e to fe6118c Compare May 21, 2026 17:56
@alexghr alexghr force-pushed the ag/fix-reject-block-proposals-in-poisoned-slots branch from d26356e to 0bc5034 Compare May 21, 2026 17:56
@alexghr alexghr force-pushed the ag/fix-reject-block-proposals-in-poisoned-slots branch from 0bc5034 to 5dfbc09 Compare May 22, 2026 10:08
@alexghr alexghr requested a review from charlielye as a code owner May 22, 2026 10:08
@alexghr alexghr changed the base branch from ag/fix-extend-slashing-of-bad-attestations to merge-train/spartan May 22, 2026 10:10
@alexghr alexghr enabled auto-merge (squash) May 22, 2026 10:17
@AztecBot
Copy link
Copy Markdown
Collaborator

Flakey Tests

🤖 says: This CI run detected 3 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033FLAKED\033 (8;;http://ci.aztec-labs.com/097aeba1d6768971�097aeba1d67689718;;�):  yarn-project/end-to-end/scripts/run_test.sh simple src/e2e_p2p/sentinel_status_slash.parallel.test.ts "slashes the proposer with INACTIVITY when checkpoint validation records invalid" (205s) (code: 0) group:e2e-p2p-epoch-flakes
\033FLAKED\033 (8;;http://ci.aztec-labs.com/1d5c9bbbf8bf029f�1d5c9bbbf8bf029f8;;�): yarn-project/end-to-end/scripts/run_test.sh ha src/composed/ha/e2e_ha_full.test.ts (313s) (code: 0)
\033FLAKED\033 (8;;http://ci.aztec-labs.com/86195dad20421049�86195dad204210498;;�): yarn-project/kv-store/scripts/run_test.sh src/sqlite-opfs/internal/ordered-binary-browser.test.ts (2s) (code: 0)

@alexghr alexghr merged commit a006f71 into merge-train/spartan May 22, 2026
23 checks passed
@alexghr alexghr deleted the ag/fix-reject-block-proposals-in-poisoned-slots branch May 22, 2026 10:34
| 'failed_txs'
| 'initial_state_mismatch'
| 'timeout'
| 'block_proposal_beyond_checkpoint'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add this to the list of slashable block proposal validation failures?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants