Skip to content

regnerated package files#13982

Open
Shams-Z wants to merge 7 commits intoAzure:masterfrom
Shams-Z:bug/fix_main_template
Open

regnerated package files#13982
Shams-Z wants to merge 7 commits intoAzure:masterfrom
Shams-Z:bug/fix_main_template

Conversation

@Shams-Z
Copy link
Copy Markdown
Contributor

@Shams-Z Shams-Z commented Apr 3, 2026

Required items, please complete

Change(s):

  • Recreated package files

Reason for Change(s):

  • validation failure for maintemplate file

Version Updated:

  • Yes

Testing Completed:

  • Help needed

Checked that the validations are passing and have addressed any issues that are present:

  • Help needed

@Shams-Z Shams-Z requested review from a team as code owners April 3, 2026 05:48
@v-shukore v-shukore added the Solution Solution specialty review needed label Apr 3, 2026
"_dataConnectorContentIdConnections": "VisaThreatIntelligenceConnectorTemplateConnections",
"dataConnectorTemplateNameConnections": "[concat(parameters('workspace'),'-dc-',uniquestring(variables('_dataConnectorContentIdConnections')))]",
"_logAnalyticsTableId1": "VisaThreatIntelligenceIOC_CL",
"_solutionAuthor": "Visa Inc.",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update values

"name": "[variables('_solutionAuthor')]",
"tier": "[variables('_solutionTier')]",

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the places where the variables are set. I don't see any other places where we define these variables

@Shams-Z
Copy link
Copy Markdown
Contributor Author

Shams-Z commented Apr 4, 2026

these are all the reference to the tier

image

@v-maheshbh v-maheshbh requested a review from Copilot April 6, 2026 08:06
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Regenerates the Visa Threat Intelligence (VTI) solution package artifacts to address a template validation failure and bumps solution version metadata.

Changes:

  • Added regenerated ARM package templates and UI definition under Solutions/Visa Threat Intelligence (VTI)/Package/.
  • Added/updated solution definition file Solutions/Visa Threat Intelligence (VTI)/Data/Solution_VTI.json with solution metadata, version, and content lists.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 5 comments.

File Description
Solutions/Visa Threat Intelligence (VTI)/Package/testParameters.json Package artifact (ignored for review per repo guidelines).
Solutions/Visa Threat Intelligence (VTI)/Package/mainTemplate.json Package artifact (ignored for review per repo guidelines).
Solutions/Visa Threat Intelligence (VTI)/Package/createUiDefinition.json Package artifact (ignored for review per repo guidelines).
Solutions/Visa Threat Intelligence (VTI)/Data/Solution_VTI.json Defines solution metadata and component inventory; needs adjustments to meet solution-data validation rules.

@@ -0,0 +1,29 @@
{
"Name": "Visa Threat Intelligence (VTI)",
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The solution Name contains special characters ( and ) which violates the solution-data naming requirement (only alphanumeric characters and spaces). Update the display name to remove special characters (for example, “Visa Threat Intelligence VTI”) while keeping it aligned with the solution folder naming expectations.

Copilot generated this review using guidance from repository custom instructions.
Shams-Z and others added 2 commits April 6, 2026 09:51
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Shams-Z
Copy link
Copy Markdown
Contributor Author

Shams-Z commented Apr 7, 2026

@sreedharande @v-shukore @v-maheshbh The PR check is stuck from yesterday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Solution Solution specialty review needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants