Migrated Dynatrace Solution to use DCR#14003
Open
keyoke wants to merge 83 commits intoAzure:masterfrom
Open
Conversation
….com/keyoke/Azure-Sentinel into users/gaemslie/migrate-dynatrace-ccp
….com/keyoke/Azure-Sentinel into users/gaemslie/migrate-dynatrace-ccp
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Migrates the Dynatrace solution to support DCR-based v2 connectors while keeping existing v1 connectors and updating parsers/release notes to accommodate the new schemas.
Changes:
- Added v2 (DCR-based) Dynatrace connector assets (definitions, polling configs, DCRs, and tables) alongside existing v1 connectors.
- Updated Dynatrace parsers to union v1 and v2 custom tables into a single function interface.
- Updated solution metadata/release notes to reflect the DCR connector addition.
Reviewed changes
Copilot reviewed 28 out of 30 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| Solutions/Dynatrace/ReleaseNotes.md | Updates release notes entry for the new DCR-based connectors. |
| Solutions/Dynatrace/Parsers/DynatraceSecurityProblems.yaml | Adds v2 table support and unions v1/v2 outputs. |
| Solutions/Dynatrace/Parsers/DynatraceProblems.yaml | Adds v2 table support and unions v1/v2 outputs. |
| Solutions/Dynatrace/Parsers/DynatraceAuditLogs.yaml | Adds v2 table support and unions v1/v2 outputs. |
| Solutions/Dynatrace/Parsers/DynatraceAttacks.yaml | Adds v2 table support and unions v1/v2 outputs. |
| Solutions/Dynatrace/Package/testParameters.json | Not reviewed (ignored path per repo review rules). |
| Solutions/Dynatrace/Package/createUiDefinition.json | Not reviewed (ignored path per repo review rules). |
| Solutions/Dynatrace/Data/Solution_Dynatrace.json | Updates solution data definition to include v2 connector artifacts. |
| Solutions/Dynatrace/Data Connectors/Connector_Dynatrace_RuntimeVulnerabilities_table.json | Not reviewed (ignored path per repo review rules). |
| Solutions/Dynatrace/Data Connectors/Connector_Dynatrace_RuntimeVulnerabilities_Polling_Config.json | Not reviewed (ignored path per repo review rules). |
| Solutions/Dynatrace/Data Connectors/Connector_Dynatrace_RuntimeVulnerabilities_Definition.json | Not reviewed (ignored path per repo review rules). |
| Solutions/Dynatrace/Data Connectors/Connector_Dynatrace_RuntimeVulnerabilities_DCR.json | Not reviewed (ignored path per repo review rules). |
| Solutions/Dynatrace/Data Connectors/Connector_Dynatrace_RuntimeVulnerabilities.json | Not reviewed (ignored path per repo review rules). |
| Solutions/Dynatrace/Data Connectors/Connector_Dynatrace_Problems_table.json | Not reviewed (ignored path per repo review rules). |
| Solutions/Dynatrace/Data Connectors/Connector_Dynatrace_Problems_Polling_Config.json | Not reviewed (ignored path per repo review rules). |
| Solutions/Dynatrace/Data Connectors/Connector_Dynatrace_Problems_Definition.json | Not reviewed (ignored path per repo review rules). |
| Solutions/Dynatrace/Data Connectors/Connector_Dynatrace_Problems_DCR.json | Not reviewed (ignored path per repo review rules). |
| Solutions/Dynatrace/Data Connectors/Connector_Dynatrace_Problems.json | Not reviewed (ignored path per repo review rules). |
| Solutions/Dynatrace/Data Connectors/Connector_Dynatrace_AuditLogs_table.json | Not reviewed (ignored path per repo review rules). |
| Solutions/Dynatrace/Data Connectors/Connector_Dynatrace_AuditLogs_Polling_Config.json | Not reviewed (ignored path per repo review rules). |
| Solutions/Dynatrace/Data Connectors/Connector_Dynatrace_AuditLogs_Definition.json | Not reviewed (ignored path per repo review rules). |
| Solutions/Dynatrace/Data Connectors/Connector_Dynatrace_AuditLogs_DCR.json | Not reviewed (ignored path per repo review rules). |
| Solutions/Dynatrace/Data Connectors/Connector_Dynatrace_AuditLogs.json | Not reviewed (ignored path per repo review rules). |
| Solutions/Dynatrace/Data Connectors/Connector_Dynatrace_Attacks_table.json | Not reviewed (ignored path per repo review rules). |
| Solutions/Dynatrace/Data Connectors/Connector_Dynatrace_Attacks_Polling_Config.json | Not reviewed (ignored path per repo review rules). |
| Solutions/Dynatrace/Data Connectors/Connector_Dynatrace_Attacks_Definition.json | Not reviewed (ignored path per repo review rules). |
| Solutions/Dynatrace/Data Connectors/Connector_Dynatrace_Attacks_DCR.json | Not reviewed (ignored path per repo review rules). |
| Solutions/Dynatrace/Data Connectors/Connector_Dynatrace_Attacks.json | Not reviewed (ignored path per repo review rules). |
v-atulyadav
added
Solution
…g Microsoft Technologies used - In Log Analytics custom logs, fields ending with _d are typically already datetime. Passing a datetime into unixtime_milliseconds_todatetime() will fail at runtime.
Contributor
|
Hi @keyoke Kindly create a separate folder for the CCF connector to ensure proper structure and compliance with standards. In case multiple connectors are present, please ensure that each connector is organized within its own separate folder. Thanks! |
Contributor
Author
Hi @v-maheshbh, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required items, please complete
Change(s):
Reason for Change(s):
Version Updated:
Testing Completed:
Checked that the validations are passing and have addressed any issues that are present: