[PostgreSQL] BREAKING CHANGE: az postgres flexible-server create/update: Remove deprecated --cluster-option and update validation logic#33244
Open
nachoalonsoportillo wants to merge 4 commits intoAzure:devfrom
Conversation
…ate`: Remove deprecated `--cluster-option` and update validation logic
nachoalonsoportillo
requested review from
Pan-Qi,
VeryEarly,
calvinhzy and
jsntcy
as code owners
❌AzureCLI-FullTest
|
|
Hi @nachoalonsoportillo, |
❌AzureCLI-BreakingChangeTest
Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the deprecated --cluster-option flag from az postgres flexible-server create/update and shifts elastic-cluster detection to be implied by the presence of --node-count, updating CLI validation and scenario tests accordingly.
Changes:
- Remove deprecated
--cluster-optionargument and associated breaking-change registration. - Treat
--node-countpresence as the signal to create an elastic cluster (and gate--database-namebehind it). - Update elastic-cluster scenario tests to use
--node-countand add negative-path coverage for regular servers.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/azure-cli/azure/cli/command_modules/postgresql/utils/validators.py |
Updates cluster-related validation to rely on cluster_size (--node-count) rather than --cluster-option. |
src/azure-cli/azure/cli/command_modules/postgresql/tests/latest/test_postgres_flexible_commands_elastic_clusters.py |
Refactors scenario test flows to create/update clusters via --node-count and adds negative cases. |
src/azure-cli/azure/cli/command_modules/postgresql/commands/custom_commands.py |
Removes create_cluster plumbing and creates cluster payload only when cluster_size is provided. |
src/azure-cli/azure/cli/command_modules/postgresql/_params.py |
Removes --cluster-option parameter and updates help text/validators around --node-count and --database-name. |
src/azure-cli/azure/cli/command_modules/postgresql/_breaking_change.py |
Removes the deprecation registration for --cluster-option (and related import). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ble clusters - Updated the validation logic in the cluster validator to check for None explicitly, ensuring that the node count can only be specified for an elastic cluster. - Improved test assertions in the ElasticClustersMgmtScenarioTest to use assertEqual for location comparison, enhancing readability and accuracy.
mulander
reviewed
Apr 22, 2026
…to remove deprecated `--cluster-option` references
Member
Author
|
@calvinhzy Can you run checks on this one, please? Thanks! |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az postgres flexible-server create/updateDescription
--cluster-optionargument is deprecated. For thecreatecommand, the presence of--node-countargument implies elastic cluster, and its absence implies regular (non cluster) flexible server.Testing Guide
Adjusted existing tests to this new functionality.
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.