download: remove redundant branch and use intended value for genotyping project name#173
Merged
Merged
Conversation
grapereader
added
ready for review
ktmeaton
approved these changes
Jun 25, 2026
ktmeaton
left a comment
ktmeaton
left a comment
There was a problem hiding this comment.
That is very weird, the fix looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removed a duplicated, unreachable branch for the pedigree column in GenotypingPlateLayout.pm. Also updated the genotyping project name column to use the
$genotyping_project_namevariable defined further up in the function but previously unused.Created a PR upstream as well: solgenomics#6177
Checklist
/t/data/fixture/patches/./docshas been updated./jsto/js/source/legacy.