Skip to content

Add -DBLAKE3_USE_TBB to pkg-config CFLAGS#461

Merged
oconnor663 merged 1 commit intoBLAKE3-team:masterfrom
silvanshade:fix-pkg-config-tbb-cflags
Apr 3, 2025
Merged

Add -DBLAKE3_USE_TBB to pkg-config CFLAGS#461
oconnor663 merged 1 commit intoBLAKE3-team:masterfrom
silvanshade:fix-pkg-config-tbb-cflags

Conversation

@silvanshade
Copy link
Copy Markdown
Contributor

This PR adds -DBLAKE3_USE_TBB to the pkg-config CFLAGS.

Can you please try to include this before the next release with #460? Thanks.

@BurningEnlightenment @oconnor663

Copy link
Copy Markdown
Collaborator

@BurningEnlightenment BurningEnlightenment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh, it would be nice if the world converged on a universal dependency-spec standard with built-in support in all major build tools.

@Ericson2314
Copy link
Copy Markdown

ugh, it would be nice if the world converged on a universal dependency-spec standard with built-in support in all major build tools.

FWIW, some CMake and Meson devs are jointly working on such a thing: https://cps-org.github.io/cps/index.html#

@oconnor663 oconnor663 merged commit d81fd85 into BLAKE3-team:master Apr 3, 2025
60 checks passed
@oconnor663
Copy link
Copy Markdown
Member

I'll cut a release now. Out of curiosity, pushing a new tag to GitHub affect our callers that use CMake? Is there a dependency fetching mechanism that fetches the latest tag or anything like that?

@BurningEnlightenment
Copy link
Copy Markdown
Collaborator

Out of curiosity, pushing a new tag to GitHub affect our callers that use CMake? Is there a dependency fetching mechanism that fetches the latest tag or anything like that?

Nothing built-in but vcpkg & conan only update their ports to official tags. And of course there are probably a bunch of home-grown FetchContent based solutions which are free to do anything.

oconnor663 added a commit that referenced this pull request Apr 3, 2025
Changes since 1.8.0:
- [CMake] Fix transitive dependencies for TBB when libblake3 is built
  with BLAKE3_USE_TBB=1 (#460 and #461).
@oconnor663
Copy link
Copy Markdown
Member

Released as v1.8.1.

@BurningEnlightenment
Copy link
Copy Markdown
Collaborator

FWIW, some CMake and Meson devs are jointly working on such a thing: https://cps-org.github.io/cps/index.html#

@Ericson2314 Back when CPS was first submitted to the ISO mailing list in 2018, I sort of expected that the initiative would go nowhere and fizzle out, but apparently they added experimental support1 in CMake 3.31 and published a blog post about it this week. Though meson seems to still hold off on implementing. Interesting indeed.

Now we only have to wait 6+ years until all LTS Distros shipping incompatible build-systems are out of support 🙃

Footnotes

  1. https://cmake.org/cmake/help/latest/command/install.html#package-info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants