Remove compiler check for TBB feature#468
Merged
BurningEnlightenment merged 1 commit intoBLAKE3-team:masterfrom Apr 17, 2025
Merged
Remove compiler check for TBB feature#468BurningEnlightenment merged 1 commit intoBLAKE3-team:masterfrom
BurningEnlightenment merged 1 commit intoBLAKE3-team:masterfrom
Conversation
Compilation may work with other configurations such as MinGW under the right circumstances.
Ericson2314
approved these changes
Apr 9, 2025
|
Otherwise simple patches like this can be also applied on top of tbb until the next release in nixpkgs. |
This was referenced Apr 10, 2025
BurningEnlightenment
approved these changes
Apr 17, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compilation may work with other configurations such as MinGW under the right circumstances.
Related: #467
CC @Ericson2314
@BurningEnlightenment @oconnor663 Would it be possible to make a new patch release with this and #464? That would help resolve some downstream issues for Nix: