Skip to content

Update ip_2d_feature_extraction: Fix remaining tests (add fp tolerance via regex)#190

Merged
kostrykin merged 1 commit intoBMCV:masterfrom
kostrykin:dev/2d_feature_extraction
Jan 5, 2026
Merged

Update ip_2d_feature_extraction: Fix remaining tests (add fp tolerance via regex)#190
kostrykin merged 1 commit intoBMCV:masterfrom
kostrykin:dev/2d_feature_extraction

Conversation

@kostrykin
Copy link
Copy Markdown
Member

Follow-up of #189

https://github.com/BMCV/galaxy-image-analysis/actions/runs/20716938897 Branch push tests failed with

Output output:  different than expected, difference (using diff):
( /tmp/tmpw0inof48input11.tsv v. /tmp/tmp9fcp00q9input11.tsv )
--- local_file
+++ history_data
@@ -1,2 +1,2 @@
 area	mean_intensity	perimeter
-20825.0	129.36364945978391	590.399061660723
+20825.0	129.36364945978391	590.3990616607231

This is fixed here by utilizing compare="re_match" for floating point comparison for all remaining tests.

@kostrykin kostrykin added Partitioning and Detection Image segmentation, partitioning, and detection skip-version-check labels Jan 5, 2026
@kostrykin kostrykin merged commit 5bf032c into BMCV:master Jan 5, 2026
11 checks passed
@kostrykin kostrykin deleted the dev/2d_feature_extraction branch January 5, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Partitioning and Detection Image segmentation, partitioning, and detection skip-version-check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant