refactor: improve type hints and code style across multiple files library up to symfony 7.4.x - #50
Open
ColonelMoutarde wants to merge 5 commits into
Open
Conversation
…rary up to symfony 7.4.x
t-geindre
approved these changes
Apr 13, 2026
e-zannelli
reviewed
Apr 20, 2026
shavounet
approved these changes
Apr 20, 2026
shavounet
left a comment
shavounet
left a comment
There was a problem hiding this comment.
Quick overview, LGTM, a few comments still
e-zannelli
reviewed
Apr 21, 2026
Co-authored-by: e-zannelli <41945822+e-zannelli@users.noreply.github.com>
e-zannelli
reviewed
Apr 21, 2026
Author
|
Up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I think this PR introduces some BC breaks. We should tag a major version.