feat: bump amp to v3 - #52
Open
Yokann wants to merge 13 commits into
Open
Conversation
Yokann
force-pushed
the
feat/bump-amp-v3
branch
2 times, most recently
from
August 23, 2023 12:20
b33e40f to
820cea4
Compare
Yokann
marked this pull request as ready for review
August 23, 2023 12:39
Yokann
marked this pull request as draft
August 24, 2023 07:27
antten
reviewed
Apr 30, 2026
- Remove useless comment - Move property declaration and constructor at the top of the class - Remove useless index declaration
e-zannelli
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AMPHP use now Fiber via Revolt eventloop.
I made this PR to update the current AMPHP implementation of Tornado to this new version.
I don't think it's a good idea to keep both implementation of AMP (2.6 and 3.0)
Documentaion
https://amphp.org/upgrade
https://revolt.run/fundamentals