fix(base): 🐛 make socket-closed detection portable to Windows#666
Merged
Conversation
- replace socket.MSG_DONTWAIT (POSIX-only, missing on Windows) with settimeout(0), which puts the socket into non-blocking mode portably and raises the same BlockingIOError the existing handler expects - MSG_PEEK alone still reads without consuming the data Fixes 3 tests in TestIsSocketClosed that previously failed on Windows because evaluating socket.MSG_DONTWAIT raised AttributeError before recv() was ever reached, silently falling through to the generic exception handler instead of exercising the intended branch. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 3 tests in TestIsSocketClosed that previously failed on Windows because evaluating socket.MSG_DONTWAIT raised AttributeError before recv() was ever reached, silently falling through to the generic exception handler instead of exercising the intended branch.