Skip to content

roles/dhcp: Fix concurrency issues on discover. #2149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
romanlum wants to merge 4 commits into
base: main
Choose a base branch
from

Add more tests to reach coverage goal

c076c14
Select commit
Loading
Failed to load commit list.
Open

roles/dhcp: Fix concurrency issues on discover. #2149

Add more tests to reach coverage goal
c076c14
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 16, 2026 in 0s

70.02% (+0.35%) compared to 9b663cc

View this Pull Request on Codecov

70.02% (+0.35%) compared to 9b663cc

Details

Codecov Report

❌ Patch coverage is 82.71605% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.02%. Comparing base (9b663cc) to head (c076c14).
⚠️ Report is 84 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
pkg/roles/dhcp/leases.go 82.60% 6 Missing and 6 partials ⚠️
pkg/roles/dhcp/dhcp_handler4_request.go 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2149      +/-   ##
==========================================
+ Coverage   69.66%   70.02%   +0.35%     
==========================================
  Files         136      136              
  Lines        7441     7519      +78     
==========================================
+ Hits         5184     5265      +81     
+ Misses       1722     1719       -3     
  Partials      535      535

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov