Skip to content

fix: mongo timezone error due to encoding#285

Merged
ninaxlee merged 2 commits into
developfrom
FIENMEE-651
Nov 17, 2025
Merged

fix: mongo timezone error due to encoding#285
ninaxlee merged 2 commits into
developfrom
FIENMEE-651

Conversation

@ninaxlee

@ninaxlee ninaxlee commented Nov 8, 2025

Copy link
Copy Markdown
Member

/schedule/daliyCount 호출 시 타임 존의 값이 오프셋으로 가는 경우가 있는데, 이 과정에서 인코딩이 없어 +를 공백 문자로 인식하는 문제를 수정합니다.

@ninaxlee ninaxlee self-assigned this Nov 8, 2025
@notion-workspace

Copy link
Copy Markdown

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @chsjen492, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

이 PR은 /schedule/dailyCount API 호출 시 타임존 정보, 특히 타임존 오프셋의 '+' 문자가 공백으로 잘못 해석되는 버그를 수정합니다. 타임존 매개변수를 올바르게 인코딩함으로써, 타임존 값이 정확하게 전송되고 해석되어 스케줄링과 관련된 데이터 불일치를 방지합니다.

Highlights

  • 타임존 인코딩: /schedule/dailyCount API 호출 시 타임존 매개변수에 encodeURIComponent를 적용하여 URL 인코딩 문제를 해결했습니다.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

안녕하세요. 타임존 문자열의 + 문자가 공백으로 인코딩되는 문제를 encodeURIComponent를 사용하여 수정한 것을 확인했습니다. 올바른 수정입니다. 추가적으로, URL 쿼리 파라미터를 생성할 때 URLSearchParams를 사용하도록 리팩토링하는 것을 제안했습니다. 이렇게 하면 향후 발생할 수 있는 유사한 인코딩 문제를 예방하고 코드의 안정성을 높일 수 있습니다.

Comment thread apps/web/src/api/schedules.ts Outdated
@ninaxlee ninaxlee merged commit 23a00a6 into develop Nov 17, 2025
2 checks passed
@ninaxlee ninaxlee deleted the FIENMEE-651 branch November 17, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants