Skip to content

chore: Add flaky test marker for failing downloads #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cbueth merged 1 commit into from
Apr 13, 2026
Merged

chore: Add flaky test marker for failing downloads #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tests/population/test_approximation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,10 @@
get_edge_population,
)

from tests.conftest import mark_xfail_flaky_download


@mark_xfail_flaky_download
def test_add_edge_population(test_city_small_copy):
"""Test the `add_edge_population` function by design."""
_, graph = test_city_small_copy
Expand Down
6 changes: 6 additions & 0 deletions tests/population/test_ghsl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,10 @@
from superblockify.config import Config
from superblockify.population import ghsl

from tests.conftest import mark_xfail_flaky_download


@mark_xfail_flaky_download
@pytest.mark.parametrize(
"resample_factor, no_window",
[
Expand Down Expand Up @@ -40,6 +43,7 @@ def test_resample_load_window_gdf(resample_factor, no_window, test_one_city_copy
assert isinstance(res_affine, Affine)


@mark_xfail_flaky_download
@pytest.mark.parametrize("window", [True, False, 1, 1.0, "test"])
def test_resample_load_window_gdf_wrong_type(window, test_one_city_copy):
"""Test loading and resampling a gdf window with wrong type."""
Expand Down Expand Up @@ -179,6 +183,7 @@ def test_get_ghsl_urls_invalid_bbox(bbox_moll):
)


@mark_xfail_flaky_download
@pytest.mark.parametrize(
"urls",
[
Expand Down Expand Up @@ -226,6 +231,7 @@ def test_download_ghsl_invalid_urls(url, save_dir):
ghsl.download_ghsl(base_path + url, save_dir=save_dir)


@mark_xfail_flaky_download
def test_download_ghsl_create_save_dir(_delete_ghsl_tifs):
"""Test the download_ghsl function with non-existent save_dir."""
url = base_path + (
Expand Down
Loading