Skip to content

"feat: add search functionality to file manager" #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rishi-Tomarji wants to merge 3 commits into
base: main
Choose a base branch
from
Open

"feat: add search functionality to file manager" #17

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5cf9449
Optimize editor detection and fixes
Rishi-Tomarji May 15, 2026
083ddb2
Merge upstream/main into main
Rishi-Tomarji May 15, 2026
d28b47e
Merge branch 'main' into main
Bimbok May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
86 changes: 50 additions & 36 deletions file_manager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,7 @@ class FileManager {
std::string cwdFile; // Path to write final CWD
std::vector<FileEntry> currentFiles;
std::vector<FileEntry> parentFiles;
std::string cachedEditor;
std::set<fs::path> multiSelection;
std::vector<fs::path> pinnedPaths;
size_t pinnedIndex = 0;
Expand Down Expand Up @@ -390,7 +391,7 @@ class FileManager {
winCurrent(nullptr), winPreview(nullptr) {
setlocale(LC_ALL, "");
loadPins();

detectEditor();
sizeWorker = std::thread(&FileManager::processSizeQueue, this);

currentPath = fs::current_path();
Expand Down Expand Up @@ -536,6 +537,21 @@ class FileManager {
setStatus("Jumped to pin");
}
}
void detectEditor() {
const char* editor = getenv("EDITOR");
const char* visual = getenv("VISUAL");

if (editor)
cachedEditor = editor;
else if (visual)
cachedEditor = visual;
else if (system("which nvim > /dev/null 2>&1") == 0)
cachedEditor = "nvim";
else if (system("which nano > /dev/null 2>&1") == 0)
cachedEditor = "nano";
else
cachedEditor = "vi";
}

const char* getIcon(const FileEntry& f) {
if (f.is_directory)
Expand Down Expand Up @@ -1541,50 +1557,48 @@ class FileManager {
}
}

void openFile() {
if (currentFiles.empty())
return;
void openFile() {
if (currentFiles.empty()) return;

const auto& file = currentFiles[selectedIndex];

if (file.is_directory) {
clearDirectRender();
currentPath = file.path;
selectedIndex = 0;
scrollOffset = 0;
reloadAll();
} else {
clearDirectRender();
def_prog_mode();
endwin();
std::string cmd;
if (VIDEO_EXTS.count(file.extension) || AUDIO_EXTS.count(file.extension)) {
clearDirectRender();
currentPath = file.path;
selectedIndex = 0;
scrollOffset = 0;
reloadAll();
return;
}

clearDirectRender();
def_prog_mode();
endwin();

std::string cmd;

if (VIDEO_EXTS.count(file.extension) || AUDIO_EXTS.count(file.extension)) {
cmd = "mpv \"" + file.path.string() + "\" 2> /dev/null";
} else if (CODE_EXTS.count(file.extension)) {
const char* editor = getenv("EDITOR");
if (!editor)
editor = getenv("VISUAL");
if (!editor) {
if (system("which nvim > /dev/null 2>&1") == 0)
editor = "nvim";
else if (system("which nano > /dev/null 2>&1") == 0)
editor = "nano";
else
editor = "vi";
}
cmd = std::string(editor) + " \"" + file.path.string() + "\"";
} else {
}
else if (CODE_EXTS.count(file.extension)) {
cmd = cachedEditor + " \"" + file.path.string() + "\"";
}
else {
#ifdef __APPLE__
cmd = "open \"" + file.path.string() + "\"";
#else
cmd = "xdg-open \"" + file.path.string() + "\"";
#endif
cmd += " > /dev/null 2>&1";
}
int res = system(cmd.c_str());
(void)res;
reset_prog_mode();
refresh();
timeout(50);
}

cmd += " > /dev/null 2>&1";

system(cmd.c_str());

reset_prog_mode();
refresh();
timeout(50);
}
}

void goUp() {
Expand Down
Loading