forked from dcatanzaro/aoweb
-
Notifications
You must be signed in to change notification settings - Fork 34
fix(api): add seed npcs.json to unblock main CI and market tests (#83) #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Rodrigoue9
wants to merge
6
commits into
Bitcoindefi:main
Choose a base branch
from
Rodrigoue9:fix/seed-npcs-json-unblock-ci
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
919b28f
fix(db): define clan_members before applying data migrations (#82)
Rodrigoue9 9daf0e1
fix(db): remove psql meta command for node-postgres compatibility in …
Rodrigoue9 21a10f1
feat: complete delivery and test suite
Rodrigoue9 392eedc
fix(api): add seed npcs.json to unblock main CI and market tests (#83)
Rodrigoue9 39a2a55
fix(api): use npcType 10 and objs array in seed merchant data
Rodrigoue9 61c424c
chore: merge origin/main into fix/seed-npcs-json-unblock-ci and resol…
Rodrigoue9 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| # feat(world-builder): register uploaded graphics and extend palette schemas (#6) | ||
|
|
||
| ## Summary | ||
| Resolves #6 by providing `paletteEntrySchema` and `validatePaletteEntry` to validate multi-layer palette definitions, enforce non-colliding graphic index allocations (`UPLOADED_GRAPHIC_INDEX_START = 1_000_000`), and verify graphic existence across engine and uploaded assets. | ||
|
|
||
| ### Changes | ||
| - Implemented `paletteEntrySchema` and `validatePaletteEntry` in `api/src/repositories/worldBuilder.ts`. | ||
| - Added unit tests in `api/src/repositories/__tests__/paletteValidation.test.ts`. | ||
|
|
||
| Closes #6 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| { | ||
| "1": { | ||
| "name": "Comerciante de Ullathorpe", | ||
| "desc": "Vendedor general de provisiones y equipamiento básico", | ||
| "npcType": 1, | ||
| "idHead": 1, | ||
| "idBody": 1, | ||
| "movement": 0, | ||
| "hp": 100, | ||
| "maxHp": 100, | ||
| "gold": 500, | ||
| "exp": 0, | ||
| "trade": [ | ||
| { | ||
| "item": 1, | ||
| "cant": 100 | ||
|
gitar-bot[bot] marked this conversation as resolved.
Outdated
|
||
| }, | ||
| { | ||
| "item": 2, | ||
| "cant": 50 | ||
| }, | ||
| { | ||
| "item": 3, | ||
| "cant": 50 | ||
| } | ||
| ] | ||
| }, | ||
| "2": { | ||
| "name": "Sacerdote", | ||
| "desc": "Cura heridas y resucita a los aventureros caídos", | ||
| "npcType": 2, | ||
| "idHead": 2, | ||
| "idBody": 2, | ||
| "movement": 0, | ||
| "hp": 250, | ||
| "maxHp": 250, | ||
| "gold": 0, | ||
| "exp": 0 | ||
| }, | ||
| "3": { | ||
| "name": "Banquero", | ||
| "desc": "Guarda oro y pertenencias en las bóvedas seguras", | ||
| "npcType": 3, | ||
| "idHead": 3, | ||
| "idBody": 3, | ||
| "movement": 0, | ||
| "hp": 200, | ||
| "maxHp": 200, | ||
| "gold": 10000, | ||
| "exp": 0 | ||
| }, | ||
| "4": { | ||
| "name": "Guardia Real", | ||
| "desc": "Protege las ciudades de criminales y criaturas salvajes", | ||
| "npcType": 4, | ||
| "idHead": 4, | ||
| "idBody": 4, | ||
| "movement": 1, | ||
| "hp": 500, | ||
| "maxHp": 500, | ||
| "minHit": 20, | ||
| "maxHit": 40, | ||
| "def": 25, | ||
| "poderAtaque": 50, | ||
| "poderEvasion": 30, | ||
| "gold": 50, | ||
| "exp": 50 | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.