Skip to content

fix(sdk): upgrade @stellar/stellar-sdk to v16 and resolve breaking changes (closes #5) - #18

Open
guptakumarranjeet150 wants to merge 3 commits into
Bitcoindefi:mainfrom
guptakumarranjeet150:feat/issue-5-upgrade-stellar-sdk-v16
Open

fix(sdk): upgrade @stellar/stellar-sdk to v16 and resolve breaking changes (closes #5)#18
guptakumarranjeet150 wants to merge 3 commits into
Bitcoindefi:mainfrom
guptakumarranjeet150:feat/issue-5-upgrade-stellar-sdk-v16

Conversation

@guptakumarranjeet150

Copy link
Copy Markdown

Summary of Changes

Upgrades @stellar/stellar-sdk from legacy ^14.4.2 to ^16.3.0 across the root package and both frontends (sgs_frontend and template_frontend), resolving v16 breaking changes and type definitions.

Details

  1. SDK Upgrade:

    • Upgraded @stellar/stellar-sdk to ^16.3.0 in package.json, sgs_frontend/package.json, and template_frontend/package.json.
    • Updated lockfiles (bun.lock) with clean dependency resolution.
    • Dropped axios in favor of native fetch under the hood, yielding a ~64% frontend bundle size reduction (~2 MB -> ~729 kB).
  2. Signer Interface & Type Alignment:

    • Aligned ContractSigner in src/types/signer.ts to directly use official SignTransaction and SignAuthEntry signatures from @stellar/stellar-sdk/contract.
    • Updated service signatures across diceDuelService.ts, numberGuessService.ts, and twentyOneService.ts to accept ContractSigner.
    • Updated injectSignedAuthEntry in authEntryUtils.ts to use ContractSigner for player2Signer.
  3. authorizeEntry Passphrase Safety:

    • Verified that all invocations of authorizeEntry (authEntryUtils, diceDuelService, numberGuessService, twentyOneService) strictly provide explicit networkPassphrase (tx.options.networkPassphrase or NETWORK_PASSPHRASE), complying with the v16 breaking change where the default was removed.
  4. Documentation & Prerequisites:

    • Added Node.js >= 22.0.0 requirement to README.md under Prerequisites.
    • Rebuilt production documentation bundle in docs/ using the updated v16 runtime.

Verification

  • bun --cwd=sgs_frontend run build succeeds (TypeScript compilation + Vite build with 0 errors)
  • bun --cwd=template_frontend run build succeeds (TypeScript compilation + Vite build with 0 errors)
  • bun --cwd=sgs_frontend run build:docs succeeds and outputs clean assets to docs/

Closes #5

…hanges

- Upgrade @stellar/stellar-sdk to ^16.3.0 across root, sgs_frontend, and template_frontend
- Align ContractSigner interface with official SignTransaction and SignAuthEntry types
- Update service methods and multi-sig utilities (authEntryUtils) to accept ContractSigner
- Document Node.js >= 22.0.0 prerequisite in README.md
- Rebuild production documentation bundle in docs/ with v16 runtime

Closes Bitcoindefi#5
@gitar-bot

gitar-bot Bot commented Sep 9, 2026

Copy link
Copy Markdown

Gitar is working

Gitar

@sonarqubecloud

sonarqubecloud Bot commented Sep 9, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

el SDK de Stellar esta tres versiones mayores atrasado

1 participant