fix(sdk): upgrade @stellar/stellar-sdk to v16 and resolve breaking changes (closes #5) - #18
Open
guptakumarranjeet150 wants to merge 3 commits into
Conversation
…hanges - Upgrade @stellar/stellar-sdk to ^16.3.0 across root, sgs_frontend, and template_frontend - Align ContractSigner interface with official SignTransaction and SignAuthEntry types - Update service methods and multi-sig utilities (authEntryUtils) to accept ContractSigner - Document Node.js >= 22.0.0 prerequisite in README.md - Rebuild production documentation bundle in docs/ with v16 runtime Closes Bitcoindefi#5
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary of Changes
Upgrades
@stellar/stellar-sdkfrom legacy^14.4.2to^16.3.0across the root package and both frontends (sgs_frontendandtemplate_frontend), resolving v16 breaking changes and type definitions.Details
SDK Upgrade:
@stellar/stellar-sdkto^16.3.0inpackage.json,sgs_frontend/package.json, andtemplate_frontend/package.json.bun.lock) with clean dependency resolution.Signer Interface & Type Alignment:
ContractSignerinsrc/types/signer.tsto directly use officialSignTransactionandSignAuthEntrysignatures from@stellar/stellar-sdk/contract.diceDuelService.ts,numberGuessService.ts, andtwentyOneService.tsto acceptContractSigner.injectSignedAuthEntryinauthEntryUtils.tsto useContractSignerforplayer2Signer.authorizeEntryPassphrase Safety:authorizeEntry(authEntryUtils,diceDuelService,numberGuessService,twentyOneService) strictly provide explicitnetworkPassphrase(tx.options.networkPassphraseorNETWORK_PASSPHRASE), complying with the v16 breaking change where the default was removed.Documentation & Prerequisites:
>= 22.0.0requirement toREADME.mdunder Prerequisites.docs/using the updated v16 runtime.Verification
bun --cwd=sgs_frontend run buildsucceeds (TypeScript compilation + Vite build with 0 errors)bun --cwd=template_frontend run buildsucceeds (TypeScript compilation + Vite build with 0 errors)bun --cwd=sgs_frontend run build:docssucceeds and outputs clean assets todocs/Closes #5