Skip to content

Save Native and RTG shader parameters#2191

Merged
midwan merged 2 commits into
masterfrom
fix/save-shader-settings
Jul 19, 2026
Merged

Save Native and RTG shader parameters#2191
midwan merged 2 commits into
masterfrom
fix/save-shader-settings

Conversation

@midwan

@midwan midwan commented Jul 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add separate Shader Parameters actions beneath the Native and RTG shader selectors
  • move Reset to Shader Defaults to the top of each targeted popup and add a Save Parameters action beside it
  • persist parameter overrides independently for Native and RTG modes, including when both modes use the same shader
  • keep Save Defaults for the remaining Filter defaults: shader selections and bezel settings
  • widen the shader-related buttons so their labels remain visible

Root cause

Shader parameter edits only lived in renderer state. The Filter panel's Save Defaults action stored the selected shader names and bezel settings, but it had no serialized parameter state to restore after restarting Amiberry. A single untargeted popup also could not distinguish Native values from RTG values.

User impact

Native and RTG shader parameters can now be edited, reset, saved, and restored independently from their respective controls. Reset followed by Save removes that target's overrides and returns it to the values declared by the shader.

Validation

  • built the macOS Debug target successfully after rebasing onto the latest master
  • manually verified the revised Filter layout and unclipped button labels
  • saved different values for Native and RTG while both selected the same shader, restarted, and confirmed each popup restored its own value
  • reset and saved each target independently, confirming only that target's serialized override was removed
  • git diff --check

Parameter edits lived only in renderer state and were lost on restart. Keep Native and RTG overrides separate and expose targeted popup actions.
@midwan
midwan marked this pull request as ready for review July 19, 2026 11:09
@midwan
midwan merged commit 3a997a9 into master Jul 19, 2026
24 checks passed
@midwan
midwan deleted the fix/save-shader-settings branch July 19, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant