Save Native and RTG shader parameters#2191
Merged
Merged
Conversation
Parameter edits lived only in renderer state and were lost on restart. Keep Native and RTG overrides separate and expose targeted popup actions.
midwan
marked this pull request as ready for review
July 19, 2026 11:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Shader parameter edits only lived in renderer state. The Filter panel's Save Defaults action stored the selected shader names and bezel settings, but it had no serialized parameter state to restore after restarting Amiberry. A single untargeted popup also could not distinguish Native values from RTG values.
User impact
Native and RTG shader parameters can now be edited, reset, saved, and restored independently from their respective controls. Reset followed by Save removes that target's overrides and returns it to the values declared by the shader.
Validation
mastergit diff --check