Skip to content

Resolve bug in Tag Cloud #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NishantUpadhyay-BTC wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Resolve bug in Tag Cloud #80

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53431bf
Resolve bug in Tag Cloud
May 28, 2015
dbfbb92
Fix changes as per comments
NishantUpadhyay-BTC Dec 4, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/helpers/links_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,4 +48,8 @@ def set_tooltip_on_count(number)
def favourite_action_tooltip(link)
"#{link.favourite? ? 'Unmark ' : 'Mark'} as Favourite"
end

def user_tags
Copy link
Copy Markdown
Contributor

@amitpatelx amitpatelx May 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This helper is not needed unless used many places.

current_user.owned_tags
end
end
2 changes: 1 addition & 1 deletion app/views/links/index.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<%= render partial: 'links/links_list', locals: { links: @links}%>
</div>
<div class="col-lg-3 col-md-3 col-sm-3 showback tag-cloud-width">
<% tag_cloud Link.tag_counts, %w{s m l} do |tag, css_class| %>
<% tag_cloud user_tags, %w{s m l} do |tag, css_class| %>
<%= link_to tag.name, links_path(tag: tag.name), class: css_class %>
<% end %>
</div>
Expand Down