Skip to content

refactor: clean code improvements #1362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raymond-julie wants to merge 3 commits into
base: master
Choose a base branch
from
Open

refactor: clean code improvements #1362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
01923e4
refactor: clean code improvement (Yoda Conditions)
raymond-julie Jul 16, 2026
0955138
refactor: clean code improvement (Boolean Naming)
raymond-julie Jul 16, 2026
4465e1b
refactor: clean code improvement (Useless Else / Guard Clauses)
raymond-julie Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cdnfsd_CacheFlush.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public static function w3tc_flush_all( $extras = null ) {
$w3tc_config = Dispatcher::config();
$common = Dispatcher::component( 'Cdn_Core' );
$default_override = Cdn_Util::get_flush_manually_default_override();
if ( $w3tc_config->get_boolean( 'cdn.flush_manually', $default_override ) ) {
if ( $w3tc_config->get_boolean( 'cdn.flush_manually' ) === $default_override ) {
// in this mode flush only on purge button clicks.
if ( ! isset( $extras['ui_action'] ) ) {
return true;
Expand Down
2 changes: 1 addition & 1 deletion UsageStatistics_StorageWriter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ public function maybe_flush_hotspot_data() {
*/
public function begin_flush_hotspot_data() {
$hotspot_endtime = $this->get_hotspot_end();
if ( is_null( $hotspot_endtime ) ) {
if ( null === $hotspot_endtime ) {
// if cache not recognized - means nothing is cached at all so stats not collected.
return 'not_needed';
}
Expand Down
2 changes: 1 addition & 1 deletion lib/Google/Model.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public function __get($key)
$val = null;
}

if ($this->isAssociativeArray($val)) {
if (is_array($val) && $this->isAssociativeArray($val)) {
if (isset($this->$keyDataType) && 'map' == $this->$keyDataType) {
foreach ($val as $arrayKey => $arrayItem) {
$this->modelData[$key][$arrayKey] =
Expand Down