fix(lsp): set will_save to false in advertised sync options#3366
fix(lsp): set will_save to false in advertised sync options#3366MFS-code wants to merge 1 commit intoBoundaryML:canaryfrom
Conversation
The server advertised will_save but did not handle textDocument/willSave in a useful way (default unsupported in bex, no handler in engine). Set will_save to false so clients do not send willSave and avoid spurious errors or warnings.
|
@MFS-code is attempting to deploy a commit to the Boundary Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe LSP server capabilities in two language server implementations were updated to disable the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The server advertised will_save but did not handle textDocument/willSave in a useful way (default unsupported in bex, no handler in engine). Set will_save to false so clients do not send willSave and avoid spurious errors or warnings.
Summary by CodeRabbit