Skip to content

fix(lsp): set will_save to false in advertised sync options#3366

Open
MFS-code wants to merge 1 commit intoBoundaryML:canaryfrom
MFS-code:fix/lsp-will-save-capability
Open

fix(lsp): set will_save to false in advertised sync options#3366
MFS-code wants to merge 1 commit intoBoundaryML:canaryfrom
MFS-code:fix/lsp-will-save-capability

Conversation

@MFS-code
Copy link
Copy Markdown

@MFS-code MFS-code commented Apr 14, 2026

The server advertised will_save but did not handle textDocument/willSave in a useful way (default unsupported in bex, no handler in engine). Set will_save to false so clients do not send willSave and avoid spurious errors or warnings.

Summary by CodeRabbit

  • Bug Fixes
    • Fixed language server file synchronization behavior to improve handling of document save operations and enhance editor-server communication consistency.

The server advertised will_save but did not handle textDocument/willSave in a
useful way (default unsupported in bex, no handler in engine). Set will_save to
false so clients do not send willSave and avoid spurious errors or warnings.
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 14, 2026

@MFS-code is attempting to deploy a commit to the Boundary Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 21a75c3b-cb03-416d-aa04-d30ca8b7948e

📥 Commits

Reviewing files that changed from the base of the PR and between 6000139 and f856852.

📒 Files selected for processing (2)
  • baml_language/crates/bex_project/src/bex_lsp/multi_project/request.rs
  • engine/language_server/src/server.rs

📝 Walkthrough

Walkthrough

The LSP server capabilities in two language server implementations were updated to disable the willSave notification flag by changing it from Some(true) to Some(false), indicating the servers no longer expect willSave notifications from clients.

Changes

Cohort / File(s) Summary
LSP willSave Configuration
baml_language/crates/bex_project/src/bex_lsp/multi_project/request.rs, engine/language_server/src/server.rs
Disabled willSave flag in TextDocumentSyncOptions from Some(true) to Some(false) while preserving other sync capabilities (open_close, change, save).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 No need to save before we change,
The willSave flag now feels so strange,
False is the word, the truth we tell,
Without those warnings, all is well!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: disabling the will_save LSP capability flag across two files to prevent unsupported requests.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant